From owner-cvs-all@FreeBSD.ORG Thu Apr 5 08:39:22 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AC8F516A401; Thu, 5 Apr 2007 08:39:22 +0000 (UTC) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: from svm.csie.ntu.edu.tw (svm.csie.ntu.edu.tw [140.112.90.75]) by mx1.freebsd.org (Postfix) with ESMTP id 3A95113C465; Thu, 5 Apr 2007 08:39:21 +0000 (UTC) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: from svm.csie.ntu.edu.tw (localhost [127.0.0.1]) by svm.csie.ntu.edu.tw (8.13.8/8.13.8) with ESMTP id l358dKee031854; Thu, 5 Apr 2007 16:39:20 +0800 (CST) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: (from rafan@localhost) by svm.csie.ntu.edu.tw (8.13.8/8.13.8/Submit) id l358dKXV009380; Thu, 5 Apr 2007 16:39:20 +0800 (CST) (envelope-from rafan) Date: Thu, 5 Apr 2007 16:39:20 +0800 From: Rong-En Fan To: Jason Harris Message-ID: <20070405083920.GL3330@svm.csie.ntu.edu.tw> References: <200704041702.l34H222T004152__31953.9864351556$1175706304$gmane$org@repoman.freebsd.org> <20070404191038.GA15948@wilma.widomaker.com> <4613FB27.9030107@FreeBSD.org> <200704041702.l34H222T004152__31953.9864351556$1175706304$gmane$org@repoman.freebsd.org> <20070404191038.GA15948@wilma.widomaker.com> <20070404192011.GJ55471@svm.csie.ntu.edu.tw> <20070404213309.GA18092@wilma.widomaker.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C4ZO9l7mQWyMv5+Y" Content-Disposition: inline In-Reply-To: <20070404213309.GA18092@wilma.widomaker.com> User-Agent: Mutt/1.5.14 (2007-02-12) Cc: Mark Linimon , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Gabor Kovesdan , cvs-ports@FreeBSD.org, Rong-En Fan Subject: Re: cvs commit: ports/ports-mgmt/portmk/Mk bsd.port.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2007 08:39:22 -0000 --C4ZO9l7mQWyMv5+Y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 04, 2007 at 05:33:09PM -0400, Jason Harris wrote: > On Thu, Apr 05, 2007 at 03:20:11AM +0800, Rong-En Fan wrote: > > On Wed, Apr 04, 2007 at 03:10:38PM -0400, Jason Harris wrote: >=20 > > > Rather than invoke dozens of needless processes, I simply pass > > > MD5_FILE=3D/dev/null to the "make fetch" in the makesum target. > > > (Note that this also removes the need to set NO_CHECKSUM=3Dyes and > > > DISABLE_SIZE=3Dyes in the same target, further simplfying things.) > >=20 > > Note that it does not solve 'make fetch' when there is no MD5_FILE > > (this is another regression with latest bsd.port.mk). DISTINFO_DATA > > still needs to check existence of MD5_FILE. >=20 > Remember, this is the "make makesum" step we're all (supposed to be) > talking about. That is, MD5_FILE is truncated to 0 bytes and is > added to in several steps. The regression, AFAICT, is that awk > is run when MD5_FILE doesn't exist (rather than empty/truncated), > returns non-zero, and kills the make. I understand what you said in previous mail. I just want to point out the regression is not only restricted to 'make makesum' :-) Regards, Rong-En Fan --C4ZO9l7mQWyMv5+Y Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGFLU9144QkYb9jGgRAkW6AKCKFDW2jdifYSSAEj1XT4HjNeutpgCfUh8l /cVT1VaOzp3zrX1N+ubgLXg= =rvuN -----END PGP SIGNATURE----- --C4ZO9l7mQWyMv5+Y--