From owner-svn-src-all@freebsd.org Wed Apr 24 17:54:49 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E69C0159F5A7; Wed, 24 Apr 2019 17:54:48 +0000 (UTC) (envelope-from chagin.dmitry@gmail.com) Received: from mail-it1-f175.google.com (mail-it1-f175.google.com [209.85.166.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 055087222A; Wed, 24 Apr 2019 17:54:47 +0000 (UTC) (envelope-from chagin.dmitry@gmail.com) Received: by mail-it1-f175.google.com with SMTP id e13so7709185itk.4; Wed, 24 Apr 2019 10:54:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hXZCeQ8Gar9dEYF6qiE4YllXtohog9QSXrifcKmT1Go=; b=QzuFzgU9yc3HwcRlX2cWLfvaEZhz7RV2TK+hB7Tw2UOkzg67HVCAz4td4Fg1BeD6RJ xweH1T+A3VQfk3kpf3vfOf5PUlZzxATmS78qOpAR9CpYR+BWlv4f4moApQBwkGoLHQTX bXuRjq96jeleBxtHNWXfWJfawjeJgUtIztErbKYBXhVYAPd+bZTIeK2hg+I8tFVxeRrQ O2b4A/E20cR/WaLTKYR19xHzskVESLjXBo7lz2os3kkpW+cm/hW0DLH2zDt9XmJpWcdz MEFXqsOhatLm7wREt5so1jrTGtF6J92E5iCWXeicHqcB9LmP754W3TsALlPkaxVVLxwT tn+w== X-Gm-Message-State: APjAAAXKiW4hqwqgE2+n37MueW3UwWNab+xqzVwYcqLWctH+cAOtSUNW blksCdDgxW/io87O3f9R9UNe2R9jyP/I7xIDJ4C+Zw== X-Google-Smtp-Source: APXvYqx5dA/2CrDWqmHIRc2A7Zeflca2AURjC8pvomECFjwyUyDNV+q9ekC148ySJ97J3tLKDk4iQPsNxfzFvEPQaeA= X-Received: by 2002:a02:630d:: with SMTP id j13mr21632777jac.142.1556128480809; Wed, 24 Apr 2019 10:54:40 -0700 (PDT) MIME-Version: 1.0 References: <201904161326.x3GDQV9J003308@repo.freebsd.org> In-Reply-To: <201904161326.x3GDQV9J003308@repo.freebsd.org> From: Dmitry Chagin Date: Wed, 24 Apr 2019 20:54:30 +0300 Message-ID: Subject: Re: svn commit: r346273 - in head/sys: compat/freebsd32 kern To: Ed Maste Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 055087222A X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of chagindmitry@gmail.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=chagindmitry@gmail.com X-Spamd-Result: default: False [-5.43 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MIME_TRACE(0.00)[0:+,1:+]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_TLS_LAST(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.96)[-0.960,0]; RCVD_IN_DNSWL_NONE(0.00)[175.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.46)[ip: (-6.10), ipnet: 209.85.128.0/17(-3.88), asn: 15169(-2.26), country: US(-0.06)]; FORGED_SENDER(0.30)[dchagin@freebsd.org,chagindmitry@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[dchagin@freebsd.org,chagindmitry@gmail.com]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2019 17:54:49 -0000 =D0=B2=D1=82, 16 =D0=B0=D0=BF=D1=80. 2019 =D0=B3. =D0=B2 16:26, Ed Maste : > Author: emaste > Date: Tue Apr 16 13:26:31 2019 > New Revision: 346273 > URL: https://svnweb.freebsd.org/changeset/base/346273 > > Log: > correct readlinkat(2) return type > > Hi, Ed make sysent? > r176215 corrected readlink(2)'s return type and the type of the last > argument. readlink(2) was introduced in r177788 after being developed > as part of Google Summer of Code 2007; it appears to have inherited the > wrong return type. > > Man pages and header files were already ssize_t; update syscalls.master > to match. > > PR: 197915 > Submitted by: Henning Petersen > MFC after: 2 weeks > > Modified: > head/sys/compat/freebsd32/syscalls.master > head/sys/kern/syscalls.master > > Modified: head/sys/compat/freebsd32/syscalls.master > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/compat/freebsd32/syscalls.master Tue Apr 16 12:40:49 2019 > (r346272) > +++ head/sys/compat/freebsd32/syscalls.master Tue Apr 16 13:26:31 2019 > (r346273) > @@ -963,7 +963,7 @@ > uint32_t dev); } > 499 AUE_OPENAT_RWTC NOPROTO { int openat(int fd, const char *path, \ > int flag, mode_t mode); } > -500 AUE_READLINKAT NOPROTO { int readlinkat(int fd, const char *path= , > \ > +500 AUE_READLINKAT NOPROTO { ssize_t readlinkat(int fd, const char > *path, \ > char *buf, size_t bufsize); } > 501 AUE_RENAMEAT NOPROTO { int renameat(int oldfd, const char *old= , > \ > int newfd, const char *new); } > > Modified: head/sys/kern/syscalls.master > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/syscalls.master Tue Apr 16 12:40:49 2019 > (r346272) > +++ head/sys/kern/syscalls.master Tue Apr 16 13:26:31 2019 > (r346273) > @@ -2716,7 +2716,7 @@ > ); > } > 500 AUE_READLINKAT STD { > - int readlinkat( > + ssize_t readlinkat( > int fd, > _In_z_ const char *path, > _Out_writes_bytes_(bufsize) char *buf, > >