From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Sep  4 11:53:29 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 26CE8597
 for <freebsd-ports-bugs@FreeBSD.org>; Thu,  4 Sep 2014 11:53:29 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0D67A1C2E
 for <freebsd-ports-bugs@FreeBSD.org>; Thu,  4 Sep 2014 11:53:29 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s84BrSjl054110
 for <freebsd-ports-bugs@FreeBSD.org>; Thu, 4 Sep 2014 11:53:28 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 191562] [new port] sysutils/rundeck Rundeck - remote node
 orchestration server
Date: Thu, 04 Sep 2014 11:53:27 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports Tree
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: marino@FreeBSD.org
X-Bugzilla-Status: In Discussion
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-191562-13-7PlWj8gA8s@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-191562-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-191562-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Sep 2014 11:53:29 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191562

--- Comment #9 from John Marino <marino@FreeBSD.org> ---
Quick review:

I guess nothing is wrong with users, I see now it's a substition.

However:

Issue 1) Please respect 80-column limits.  Use "\" to wrap lines.  I see a
couple of places this is needed.

Issue 2) regarding this code:

+.include <bsd.port.pre.mk>
+
+do-install:
+    ${MKDIR} ${STAGEDIR}${DATADIR} ${STAGEDIR}${RUNDECK_HOME}/server/lib
+    ${INSTALL_DATA} ${DISTDIR}/${DIST_SUBDIR}/${DISTNAME}${EXTRACT_SUFX}
${STAGEDIR}${DATADIR}/${PORTNAME}-launcher${EXTRACT_SUFX}
+
+.include <bsd.port.post.mk>


Question 2A) Why is <pre> and <post> needed here?
Request 2B)  Please replace ${PORTNAME} with "rundeck".  If I changed the name
the port, the do-install would break.  I know that *TONS* of people do exactly
this and I think it's outright wrong.


If you use jenkins, that's fine, but attach the log that proves this builds
cleanly.

-- 
You are receiving this mail because:
You are the assignee for the bug.