From owner-svn-src-all@freebsd.org Thu Feb 6 16:31:00 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 412E722FD3C; Thu, 6 Feb 2020 16:31:00 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48D3pC2mkHz4D57; Thu, 6 Feb 2020 16:30:58 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x731.google.com with SMTP id x82so6105465qkb.8; Thu, 06 Feb 2020 08:30:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PJ6tbkfhkenOO72bVEIqtA9q8YdChu97SBfV5CyRhTo=; b=RFGbLnjkh8hDc52tAVZjwzWEnawtXsAqeVkI63UUHmSjrOAPe7DwpE7pY8bGL/QRNQ 1eQKgV+DjHcuD/U+jypFTMUagRmkgMS0b/dHaw/AwjaQC76Y63E9vOM2Z2+egtHglV68 F2crIIOKV5bStLms/Hs3YB1NPErZFjhZGj9u/oYQqflOIu5PG1xQyju9LoX8SLxouTZo CGDV09tb7x6IxzTxRaBHqdHNEGOdk+j51px1gzlwodLhN2fQbYUBHlR3pIyuk25BUgBE 8kHVMakgeAKEZKc7wSgdt4WgVSncEH0OMDD+EYV2LSbW8dE9K8Y/bQzRMk17AyZRYImE 2h+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=PJ6tbkfhkenOO72bVEIqtA9q8YdChu97SBfV5CyRhTo=; b=LjtwqrlYZMSfqdipg2LEaC1umhD+rxoh2+zEqpcv5+l2ewnBLab8JQxHIZ5SHt6EMp zz+Ud05xED0crbBq5vwdDECHHZC+zgY8WlogtMi2sxM4sIcaLifYaW5pzPvj6VDZ8Ca/ qmRDw2znXc1KPII2I6gW1AYiY8zix9Fm7vNeIhmpjbInpIGST53aXPyZQ/txOs5X6Vfc wLLTEIIpYqgZQBHHlu5IgCwPtqj0xxJPz00vEPAnBezGGRsU4LCEuaDjMCVevcBBgcJA pCX2t1sdwTxE8px3cZY3pZE9C034WmpPvci2FmWvLgQN9VKPpVPLWF4dOn6E7rQWM7A/ NH+w== X-Gm-Message-State: APjAAAVr0ux+2XOe6hudCLh09kzP9HiXzeOFV8Wzd561vm48/7lf9onh LnGMUaEHXNTzGpN83BqT3IEgzPqk X-Google-Smtp-Source: APXvYqx9T4kxWOb9diqt7+51BmYJGefN7cN3bUWghRogRRUege9+6tctjKrMIt8FO3z2lfy7d+uRxA== X-Received: by 2002:a37:f518:: with SMTP id l24mr3064183qkk.441.1581006657663; Thu, 06 Feb 2020 08:30:57 -0800 (PST) Received: from spy (ip-45-3-14-96.user.start.ca. [45.3.14.96]) by smtp.gmail.com with ESMTPSA id d25sm1614988qka.39.2020.02.06.08.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2020 08:30:56 -0800 (PST) Sender: Mark Johnston Date: Thu, 6 Feb 2020 11:30:55 -0500 From: Mark Johnston To: Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356818 - in head/sys/geom: . concat eli gate journal linux_lvm mirror nop part raid raid3 shsec stripe Message-ID: <20200206163055.GB60144@spy> References: <202001170115.00H1FtSu082373@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202001170115.00H1FtSu082373@repo.freebsd.org> X-Rspamd-Queue-Id: 48D3pC2mkHz4D57 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=RFGbLnjk; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::731 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-4.29 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-2.59)[ip: (-9.20), ipnet: 2607:f8b0::/32(-1.97), asn: 15169(-1.74), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[1.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Feb 2020 16:31:00 -0000 On Fri, Jan 17, 2020 at 01:15:55AM +0000, Warner Losh wrote: > Author: imp > Date: Fri Jan 17 01:15:55 2020 > New Revision: 356818 > URL: https://svnweb.freebsd.org/changeset/base/356818 > > Log: > Pass BIO_SPEEDUP through all the geom layers > > While some geom layers pass unknown commands down, not all do. For the ones that > don't, pass BIO_SPEEDUP down to the providers that constittue the geom, as > applicable. No changes to vinum or virstor because I was unsure how to add this > support, and I'm also unsure how to test these. gvinum doesn't implement > BIO_FLUSH either, so it may just be poorly maintained. gvirstor is for testing > and not supportig BIO_SPEEDUP is fine. > > Reviewed by: chs > Differential Revision: https://reviews.freebsd.org/D23183 Hi Warner, BIO_SPEEDUP triggers an assertion failure in virtblk, as found by syzkaller. I'm not sure how best to handle it - I don't think there's anything the driver can really do with BIO_SPEEDUP, so it could be dropped, but maybe it's unexpected that it's made it to this layer in the first place. http://syzkaller.backtrace.io:8080/file?name=crashes%2f1e84321d4576307b788b7c3e4526facc7d10a46c%2freport0