From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Dec 16 16:10:01 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29AD616A41B for ; Sun, 16 Dec 2007 16:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0278213C4D3 for ; Sun, 16 Dec 2007 16:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lBGGA0A5081235 for ; Sun, 16 Dec 2007 16:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lBGGA0qJ081234; Sun, 16 Dec 2007 16:10:00 GMT (envelope-from gnats) Resent-Date: Sun, 16 Dec 2007 16:10:00 GMT Resent-Message-Id: <200712161610.lBGGA0qJ081234@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Alejandro Pulver" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 432C816A420 for ; Sun, 16 Dec 2007 16:08:29 +0000 (UTC) (envelope-from alepulver@FreeBSD.org) Received: from relay03.pair.com (relay03.pair.com [209.68.5.17]) by mx1.freebsd.org (Postfix) with SMTP id CC24C13C442 for ; Sun, 16 Dec 2007 16:08:28 +0000 (UTC) (envelope-from alepulver@FreeBSD.org) Received: (qmail 18128 invoked from network); 16 Dec 2007 16:08:27 -0000 Received: from unknown (HELO deimos.mars.bsd) (unknown) by unknown with SMTP; 16 Dec 2007 16:08:27 -0000 Message-Id: <1197821309.2615@deimos.mars.bsd> Date: Sun, 16 Dec 2007 13:08:29 -0300 From: "Alejandro Pulver" To: "FreeBSD gnats submit" X-Send-Pr-Version: gtk-send-pr 0.4.8 Cc: Subject: ports/118749: [PATCH] bsd.commands.mk: add missing UNMAKESELF_CMD, required by USE_MAKESELF X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Dec 2007 16:10:01 -0000 >Number: 118749 >Category: ports >Synopsis: [PATCH] bsd.commands.mk: add missing UNMAKESELF_CMD, required by USE_MAKESELF >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Sun Dec 16 16:10:00 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Alejandro Pulver >Release: FreeBSD 6.2-RELEASE i386 >Organization: >Environment: System: FreeBSD 6.2-RELEASE #0: Fri Jan 12 11:05:30 UTC 2007 root@dessler.cse.buffalo.edu:/usr/obj/usr/src/sys/SMP >Description: The (relatively) new USE_MAKESELF doesn't work because it leaves EXTRACT_CMD undefined, thus later trying to execute the distfile. >From bsd.port.mk: .elif defined(USE_MAKESELF) EXTRACT_CMD?= ${UNMAKESELF_CMD} But it's not defined, so it should be added in bsd.commands.mk as UNZIP_CMD, etc. >How-To-Repeat: >Fix: Index: ports/Mk/bsd.commands.mk =================================================================== RCS file: /home/pcvs/ports/Mk/bsd.commands.mk,v retrieving revision 1.1 diff -u -r1.1 bsd.commands.mk --- ports/Mk/bsd.commands.mk 4 Aug 2007 11:37:23 -0000 1.1 +++ ports/Mk/bsd.commands.mk 16 Dec 2007 15:55:51 -0000 @@ -83,6 +83,7 @@ TRUE?= true # Shell builtin UMOUNT?= /sbin/umount UNAME?= /usr/bin/uname +UNMAKESELF_CMD?= ${LOCALBASE}/bin/unmakeself UNZIP_CMD?= ${LOCALBASE}/bin/unzip WHICH?= /usr/bin/which XARGS?= /usr/bin/xargs >Release-Note: >Audit-Trail: >Unformatted: