From owner-svn-src-all@FreeBSD.ORG Sun Feb 15 19:01:03 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A2C391FB; Sun, 15 Feb 2015 19:01:03 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0E2E1A02; Sun, 15 Feb 2015 19:01:02 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t1FJ10TV044897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 15 Feb 2015 22:01:00 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t1FJ10f2044896; Sun, 15 Feb 2015 22:01:00 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sun, 15 Feb 2015 22:01:00 +0300 From: Gleb Smirnoff To: Craig Rodrigues Subject: Re: svn commit: r276747 - head/sys/netpfil/pf Message-ID: <20150215190100.GQ15484@FreeBSD.org> References: <201501060903.t06934qp081875@svn.freebsd.org> <20150122012709.GM15484@FreeBSD.org> <54C16715.6060701@gmx.com> <20150122222314.GO15484@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Nikos Vassiliadis , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2015 19:01:03 -0000 Craig, On Sat, Feb 14, 2015 at 07:35:53PM -0800, Craig Rodrigues wrote: C> > On Thu, Jan 22, 2015 at 10:09:41PM +0100, Nikos Vassiliadis wrote: C> > N> > Sorry guys, I backed this out due to broken kldunload of pf module, C> > which C> > N> > is critical when you are working with pf bugs. C> > N> C> > N> For sure. 100% understood. C> > N> C> > N> > I had to backout r276746 as well, since it has numerous build C> > breakages, C> > N> > that are addressed by later revisions. C> > N> > C> > N> > That's my fault that I don't review in time, and I will try to improve C> > N> > the situation. C> > N> > C> > N> > Can you please replay r276746 again, addressing all the build problems C> > N> > and send the patch to me? You can user reviews.freebsd.org if you C> > want. C> > N> > C> > N> > I'd like to get this in, but in a better quality. C> > N> C> > N> I'd like to get involved again and help you fixing pf. Craig could you C> > N> replay 276746? C> C> I wish you could have fixed the pf unload problem without backing out C> all these changes. I took all these changes from your projects/pf branch, C> which was starting to bitrot because it was not being sync'd with head. C> C> I got confirmation from several people that the fixes as they were (after C> the build break fixes), C> actually fixed their issues with PF and VIMAGE, which have been pending for C> several C> years now with no visible progress made. C> C> Most regular users of PF don't really kldunload it once it is used. C> For development use, I've been testing inside bhyve VM's, which doesn't C> solve the kldunload problem but allows testing and forward progress. C> C> Why do you want me to replay 276746 and give you a patch? C> C> Why don't you just do it yourself? Because it is responsibility of the committer, who broke something, to fix it, not mine. Nevertheless, I tried to do that, and it took more than couple of hours, but I failed to untangle all the problems that r276746 brought and proceeded with checkout. -- Totus tuus, Glebius.