From nobody Sun Nov 23 13:34:19 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dDqjd4HPsz6GywX for ; Sun, 23 Nov 2025 13:36:21 +0000 (UTC) (envelope-from bogorodskiy@gmail.com) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dDqjc5pHSz3jZF for ; Sun, 23 Nov 2025 13:36:20 +0000 (UTC) (envelope-from bogorodskiy@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-b736cd741c1so596168866b.0 for ; Sun, 23 Nov 2025 05:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763904973; x=1764509773; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=JB2h3snj0+UWCmW/VEm2ezui77m9O4KsiVCAuji6+GQ=; b=kk+hhjP6dVl1aY1clwtZaWA1fqVR1W4kunERaLXxa9dQ+vOaNqh0gyenxYydFEkOdS IigxmIok8V6sBlNpLD6AVgzGTIeu/oSEEl/EoboVq+25KmYpEna9TYdBC7l5jeyVVY7W qyo7ZHVqbYyzJ6RBR1k9vm1C0vSll8JOzHhjsN080T7YFPAs+FHSPYgxb+TfQOR5YFfo UNreceD/ehUJ3/9OP0woT2AwtK8fdgI85Py7KPewL0cSRPtPgO19bLtsuJQj+ZAc0zuQ /1QCoL9gWBdxBOlP9BM74dmxmPXNw4v+eh3MZe9OU7sv3T4jXYAFmheweXY0ZwfUP7gT 3Kvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763904973; x=1764509773; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JB2h3snj0+UWCmW/VEm2ezui77m9O4KsiVCAuji6+GQ=; b=uRbiFsVd5HjkS9P/1/T+aHPwxZ0QVlBkY7zRzvqbzqNMnvi0c+AsPKZ5HFiDgvtToz TfnIsaCmGdfOacR/ME7nJoFIIjkTWTu7jCb8eVZpDT2wOokzWk5HiUTHPLsd/Cc9ynCn VlKSfglkj6nhoM0erbZbYCbIpxnACm4ndPPewcZ9xMuNTMJI61BH/ye8deBjnbPdc6Q3 zCGHX9PgQKFQjVK8HbMb3Nnwf19tP0dOyoPXiwKYrkgZY+wYGXwxzQ9xdrsgoTEszIg0 BassW7Qa+nvrKu6G47/VwzkSlFJB2k4i0P/xpEra4TQyRgiwuqP51pd1wOQPAfyAvqKq dEIA== X-Forwarded-Encrypted: i=1; AJvYcCWaviIP0SUlQyATbBCWVVS1K4hNBMJe/RUDyGe+L9UIAoH0iVk9psVNSTTedoCenX/tMWU9fG1W9kKm81USDhUmmh1huQ==@freebsd.org X-Gm-Message-State: AOJu0YwULBsdUwH1d4kxcBqJBkIhyfsvjIGzfH4LNFFYT8DWmSAD5YlD DbaFwEfY19Go0SNCWrmFDD1FfE5raxDrpMzsx4mHbCo/EFeXWT+I37w0 X-Gm-Gg: ASbGncsSHxOkQMtqa5D2DsZ7cNEGR6RBQ2cSG+bAyaPA5Y2gG02NWXYrAJtHaZuSCcU zhFbG5wDsJb04RpM8uwsaeVY1dT+midQSZzb1rb4G8f7Su+cpVzfjU94RRcsRvJCD7y1trGEBXA QVpeGY7ITeZVSYOSY0QPgHV0wDap+cOvCwW4kwO0fmyqJyLEQNZX9UHmXJy6FLJ3gK5mIWCMlMr PtSETvNUj1dkZF9i2M56oj6aKw398kNAHRMgDUegkueI/NQZFUIitXc6Oq//8RmNG3LAqIcozQy 4AR+2HXroyUOVjrjZeJd4mE5Oq6YekFUDsJpgNLm6BpWGuuJXMQQ1TGRlPJuK4bPRryRC2eAewL u7WyFiqAWIDyn0zgRS4Yeq+yR2WRwx+oFegSWDEkdjLbntB7nv8wFThZs883L+YR5i5h1Uj1iR4 dx8QMIYFOl8uYWLSnwx1QLXU8yuScRdWM= X-Google-Smtp-Source: AGHT+IH0+4Cd555Ow/0Bs/LVzus1Dv+A4ol/RGn1Fmq7LDQf9i+zMUJvH/0QrW54NMb9kGrp1x5YOw== X-Received: by 2002:a17:907:3e1a:b0:b73:8b7f:8c48 with SMTP id a640c23a62f3a-b76716955b4mr781990966b.37.1763904973063; Sun, 23 Nov 2025 05:36:13 -0800 (PST) Received: from tulp (84-25-144-101.cable.dynamic.v4.ziggo.nl. [84.25.144.101]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7655050d05sm992571666b.70.2025.11.23.05.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Nov 2025 05:36:12 -0800 (PST) Date: Sun, 23 Nov 2025 14:34:19 +0100 From: Roman Bogorodskiy To: Christos Margiolis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: e254ef87a30b - main - sound: Merge chn_intr() with chn_intr_locked() Message-ID: References: <69209005.3652b.58fc1f99@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dDqjc5pHSz3jZF Christos Margiolis wrote: > On Sun Nov 23, 2025 at 7:54 AM CET, Roman Bogorodskiy wrote: > > Christos Margiolis wrote: > > > >> The branch main has been updated by christos: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=e254ef87a30bfcaabc6e4d8e0ecf05f6949a4f06 > >> > >> commit e254ef87a30bfcaabc6e4d8e0ecf05f6949a4f06 > >> Author: Christos Margiolis > >> AuthorDate: 2025-11-21 16:14:28 +0000 > >> Commit: Christos Margiolis > >> CommitDate: 2025-11-21 16:14:47 +0000 > >> > >> sound: Merge chn_intr() with chn_intr_locked() > >> > >> There is no scenario where chn_intr() is called with the channel lock > >> already held. > >> > >> No functional change intended. > >> > >> Sponsored by: The FreeBSD Foundation > >> MFC after: 1 week > >> Reviewed by: kib, markj > >> Differential Revision: https://reviews.freebsd.org/D53854 > >> --- > >> sys/dev/sound/pcm/channel.c | 20 ++------------------ > >> sys/dev/sound/pcm/channel.h | 1 - > >> 2 files changed, 2 insertions(+), 19 deletions(-) > > > > With this change my system panics as soon as I start firefox: > > > > panic: _mtx_lock_sleep: recursed on non-recursive mutex dsp2.play.0 @ /usr/src/sys/dev/sound/pcm/channel.c:586 > > > > Things work fine again with this commit reverted. > > > > Roman > > Which driver are you using for your sound card? > > Christos I'm using snd_uaudio(4). If that's important, I have other pcm devices as well: $ cat /dev/sndstat Installed devices: pcm0: (play/rec) pcm1: (play/rec) pcm2: (play/rec) default No devices installed from userspace. $ dmesg |grep pcm pcm2 on uaudio0 pcm0: at nid 20 and 24 on hdaa0 pcm1: at nid 27 and 26 on hdaa0 pcm2 on uaudio0 $ Roman