From owner-svn-src-all@freebsd.org Fri Nov 2 03:37:57 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6032F10E30AD; Fri, 2 Nov 2018 03:37:57 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it1-f180.google.com (mail-it1-f180.google.com [209.85.166.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F26B57435B; Fri, 2 Nov 2018 03:37:56 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it1-f180.google.com with SMTP id t189-v6so519437itf.1; Thu, 01 Nov 2018 20:37:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=77outKWs1CYPSdg8hgSV55FTfxd5/L1YK5KD72W2Ylo=; b=Rle29Mj0nJhI1GGNv54GdbWUnpLGNuA6UUOOh5rDPRjz2tTXslw6dX5mMrT0V7uI6E +jEN+B0dK9YZckdYMGnkLex9TQJLq73uN28L8KL11UkvtkeqLqStA/UWQnfc+2ywztA5 esBsVyne4fTZWRHJdlaByvMvZpKxnB5Wl3Y64rDZoIYXBFA0X0HKNiaFVWjLiwS6tztO kKHfSRn31wZkuraeDyIPuT6QpiH3TzDUjS3oS7V+e9RzgvBRcMs6jDeY+yXufVTqjBz5 /cATo45tWbcfsHqaH8MUt4QgsbZ9Y4f45D6hTGeG8NgoJbyMwHassrCuuzM1c+DTJtdM deIw== X-Gm-Message-State: AGRZ1gJBvNL8XrBiXIqeOcDlQ5HOwik0QQfUsYIO5Ze49mYkQuebiK+Q uw8qXNJZiCEuBm6xhyaYVWc6nBC5 X-Google-Smtp-Source: AJdET5cml5DKDPVlf37aK0s/OIc0yxKCH69oen7VolURC4t9l562DsiDFExvMETax+F1ssS4eMHS2g== X-Received: by 2002:a02:15d3:: with SMTP id 80-v6mr9041947jaq.116.1541129379208; Thu, 01 Nov 2018 20:29:39 -0700 (PDT) Received: from mail-io1-f51.google.com (mail-io1-f51.google.com. [209.85.166.51]) by smtp.gmail.com with ESMTPSA id v21-v6sm10662975iob.7.2018.11.01.20.29.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Nov 2018 20:29:39 -0700 (PDT) Received: by mail-io1-f51.google.com with SMTP id o19-v6so437057iod.3; Thu, 01 Nov 2018 20:29:38 -0700 (PDT) X-Received: by 2002:a6b:1807:: with SMTP id 7-v6mr6902229ioy.143.1541129378288; Thu, 01 Nov 2018 20:29:38 -0700 (PDT) MIME-Version: 1.0 References: <201811012346.wA1NkNS5079845@repo.freebsd.org> <20181102004555.GJ5335@kib.kiev.ua> In-Reply-To: <20181102004555.GJ5335@kib.kiev.ua> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Thu, 1 Nov 2018 20:29:27 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r340038 - in head: lib/libc/sys sys/kern To: Konstantin Belousov Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 03:37:57 -0000 On Thu, Nov 1, 2018 at 5:46 PM Konstantin Belousov wrote: > > On Thu, Nov 01, 2018 at 11:46:23PM +0000, Conrad Meyer wrote: > > ... > > @@ -232,7 +232,15 @@ points outside the process's allocated address space. > > A signal was delivered before the time limit expired and > > before any of the selected events occurred. > > .It Bq Er EINVAL > > -The specified time limit is invalid. One of its components is negative or too large. > > +The specified time limit is invalid. > > +One of its components is negative or too large. > > +.It Bq Er EINVAL > > +The number of pollfd structures specified by > > +.Fa nfds > > +exceeds the system tunable > > +.Va kern.maxfilesperproc > > +and > > +.Dv FD_SETSIZE . > > This is somewhat confusing. Looking only at the man page text, most > straight reading of it is that nfds cannot exceed min(maxfilesperproc, > FD_SETSIZE). But in fact nfds cannot exceed max of it, which is > significantly different, i.e. poll(2) does not suffer from the (userspace) > FD_SETSIZE limitation of select(2). min(maxfilesperproc, FD_SETSIZE) would be written as "nfds exceeds ... maxfilesperproc OR FD_SETSIZE," rather than "and." I think the sentence is unambiguous. Best, Conrad