Date: Thu, 26 Mar 2009 17:50:04 GMT From: Andriy Gapon <avg@icyb.net.ua> To: freebsd-acpi@FreeBSD.org Subject: Re: kern/108581: [sysctl] sysctl: hw.acpi.cpu.cx_lowest: Invalid argument Message-ID: <200903261750.n2QHo41h007676@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/108581; it has been noted by GNATS.
From: Andriy Gapon <avg@icyb.net.ua>
To: Bruce Cran <bruce@cran.org.uk>
Cc: bug-followup@FreeBSD.org, lars.stokholm@gmail.com
Subject: Re: kern/108581: [sysctl] sysctl: hw.acpi.cpu.cx_lowest: Invalid
argument
Date: Thu, 26 Mar 2009 19:46:56 +0200
on 26/03/2009 17:29 John Baldwin said the following:
> I would rather move the cpu_cx_count code out into acpi_cpu_startup()
> completely. It would more closely match the _CST code in that case. It is
> also easier to follow the logic this way as well as it is only modified in
> one place and not via a secret side-effect.
Just in case:
Bruce, Lars,
could you please test John's patch (verbatim) and report back?
Thank you!
> --- //depot/vendor/freebsd/src/sys/dev/acpica/acpi_cpu.c 2009/02/19 14:40:18
> +++ //depot/user/jhb/acpipci/dev/acpica/acpi_cpu.c 2009/03/26 15:28:32
> @@ -609,10 +609,6 @@
> sc->cpu_cx_count++;
> }
> }
> -
> - /* Update the largest cx_count seen so far */
> - if (sc->cpu_cx_count > cpu_cx_count)
> - cpu_cx_count = sc->cpu_cx_count;
> }
>
> /*
> @@ -752,6 +748,8 @@
> for (i = 0; i < cpu_ndevices; i++) {
> sc = device_get_softc(cpu_devices[i]);
> acpi_cpu_generic_cx_probe(sc);
> + if (sc->cpu_cx_count > cpu_cx_count)
> + cpu_cx_count = sc->cpu_cx_count;
> }
>
> /*
>
>
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903261750.n2QHo41h007676>