From nobody Sat Mar 25 13:42:33 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PkKyK5w66z41C31; Sat, 25 Mar 2023 13:42:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PkKyK59pXz3vpn; Sat, 25 Mar 2023 13:42:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679751753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=j6C+TpfSj+Bh7m4e92IHMleRfOHPSUkes/MJr6wKRZw=; b=K19hEXfLVgwFEMDxfg+OrUSxTMUThCTLGfDEO6imcCTh6s6MGybbFLnZzdMcPbdQ779kK6 /41aJRZxMOI54+hLYqUSbCuBBocFknecAjblLyyVii5JH4gZxU42/Q3K2fXSpg1F+f4Ihl OcsDIR63hnzoG5pnLcrsKKF+0pue9G+HcwfmDgLYAKOL/i8nVBNYSTznH7G1oKHJLO7YxD iSutfzqIH9ZUzWtqKq9S2IM5xhKj3NeoDS0nXdiI9z4L93nUZ5rNeRJYWSuVi3JrUhEeRJ RIVorqiAfianfe8aThrHWzvDuox7oGX5SRUy2wCKHTA99iZnFR63ZmM44Z1waw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679751753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=j6C+TpfSj+Bh7m4e92IHMleRfOHPSUkes/MJr6wKRZw=; b=yyo6pEOOuMUzqBsSXVaVIhIVNw/Ai7ddnUfsCan/Nyg16PMs/lgl8em+b/ZjUX8PL1IuI9 THzqAuzjBwIqCGYsXYwG9tIlLEFnsP+RYQfGedu9mHsMwXkFesikU/Y3dvxJjLN2z4vU/7 dm0koo80dNaNNQ4W+RfRhQJLE4SKUNRU05VQN+fb89be10ziffoXyPBoe+IfrP6VazXHZW sWCj6X1rFQMdHNckJcAKcgo+TWIU3kKL652qIreeg1giXr4P6mxt6EXZcFYh1IXD7n2grJ QuHj1nfsVhN9ebuorS6j11qkHPVoY2i9TJ3xwWCEyr8DMtU9ViZNrqEHfXWZQg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679751753; a=rsa-sha256; cv=none; b=iy9aTdlaTJAwHBexvGAwnkruXKaOLkunRwmjIov4QqlT0wpCnf2lBYqcJG3gbvCi3IP4GQ oOk3gZs4VjN09MDMG0y1pu7r/f4Er9aqwF/iKVNPE2grLWkzMYTIvr4sufWFpW3zbt4upG yb1N/EHJm+fplouwlgcsJWNojH8peOERwSOKs0YNDv6gjZLo+nQkz+hDeFsl1gqpBTyZgX Kg5C+smsuuiPYgZKlYDWff2IIRuwVLpzoOrBsq/w1b2awIGmgW5Gh93ScqJQhiyd8YGZGP iL1FP3RR6SwgOSGkxTSIWl8/CclFFL1G3l3psmSuPdtRX16lihGiXlqjgF2TZA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PkKyK4FJwz11xL; Sat, 25 Mar 2023 13:42:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 32PDgXdJ048557; Sat, 25 Mar 2023 13:42:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 32PDgXg9048556; Sat, 25 Mar 2023 13:42:33 GMT (envelope-from git) Date: Sat, 25 Mar 2023 13:42:33 GMT Message-Id: <202303251342.32PDgXg9048556@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: 245767c2782e - main - vfs: flip deferred_inact to atomic List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 245767c2782ef2e29340be0a6755be817f16bad4 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=245767c2782ef2e29340be0a6755be817f16bad4 commit 245767c2782ef2e29340be0a6755be817f16bad4 Author: Mateusz Guzik AuthorDate: 2023-03-25 13:31:17 +0000 Commit: Mateusz Guzik CommitDate: 2023-03-25 13:42:27 +0000 vfs: flip deferred_inact to atomic Turns out it is very rarely triggered, making a per-cpu counter a waste. Examples from real life boxes: uptime counter 135 days 847 138 days 2190 141 days 1 --- sys/kern/vfs_subr.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index f8a871906e0f..72be478e310d 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -198,9 +198,9 @@ static counter_u64_t recycles_free_count; SYSCTL_COUNTER_U64(_vfs, OID_AUTO, recycles_free, CTLFLAG_RD, &recycles_free_count, "Number of free vnodes recycled to meet vnode cache targets"); -static counter_u64_t deferred_inact; -SYSCTL_COUNTER_U64(_vfs, OID_AUTO, deferred_inact, CTLFLAG_RD, &deferred_inact, - "Number of times inactive processing was deferred"); +static u_long deferred_inact; +SYSCTL_ULONG(_vfs, OID_AUTO, deferred_inact, CTLFLAG_RD, + &deferred_inact, 0, "Number of times inactive processing was deferred"); /* To keep more than one thread at a time from running vfs_getnewfsid */ static struct mtx mntid_mtx; @@ -734,7 +734,6 @@ vntblinit(void *dummy __unused) vnodes_created = counter_u64_alloc(M_WAITOK); recycles_count = counter_u64_alloc(M_WAITOK); recycles_free_count = counter_u64_alloc(M_WAITOK); - deferred_inact = counter_u64_alloc(M_WAITOK); /* * Initialize the filesystem syncer. @@ -3211,7 +3210,7 @@ vdefer_inactive(struct vnode *vp) vlazy(vp); vp->v_iflag |= VI_DEFINACT; VI_UNLOCK(vp); - counter_u64_add(deferred_inact, 1); + atomic_add_long(&deferred_inact, 1); } static void