From owner-p4-projects@FreeBSD.ORG Sat Nov 1 22:58:48 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 7B8E71065674; Sat, 1 Nov 2008 22:58:48 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F6F81065672 for ; Sat, 1 Nov 2008 22:58:48 +0000 (UTC) (envelope-from peter-gmail@wemm.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2DB6B8FC13 for ; Sat, 1 Nov 2008 22:58:48 +0000 (UTC) (envelope-from peter-gmail@wemm.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mA1Mwmkb042986 for ; Sat, 1 Nov 2008 22:58:48 GMT (envelope-from peter-gmail@wemm.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mA1Mwm4F042984 for perforce@freebsd.org; Sat, 1 Nov 2008 22:58:48 GMT (envelope-from peter-gmail@wemm.org) Date: Sat, 1 Nov 2008 22:58:48 GMT Message-Id: <200811012258.mA1Mwm4F042984@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to peter-gmail@wemm.org using -f From: Peter Wemm To: Perforce Change Reviews Cc: Subject: PERFORCE change 152332 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Nov 2008 22:58:48 -0000 http://perforce.freebsd.org/chv.cgi?CH=152332 Change 152332 by peter@peter_overcee on 2008/11/01 22:58:20 AARGH!!!! Fix the value of SIG_SETMASK in sigprocmask syscall. (It is 2 on linux, 3 on FreeBSD.) This was duplicated rather than using #includes. This is responsible for the assertion failures on non-trivial code due to signals getting unblocked when they should have remained blocked for the interpreter-driven periodic polling to find them. Affected files ... .. //depot/projects/valgrind/coregrind/m_syswrap/syscall-amd64-freebsd.S#3 edit .. //depot/projects/valgrind/coregrind/m_syswrap/syscall-x86-freebsd.S#6 edit Differences ... ==== //depot/projects/valgrind/coregrind/m_syswrap/syscall-amd64-freebsd.S#3 (text+ko) ==== @@ -71,7 +71,7 @@ */ /* from vki_arch.h */ -#define VKI_SIG_SETMASK 2 +#define VKI_SIG_SETMASK 3 .globl ML_(do_syscall_for_client_WRK) ML_(do_syscall_for_client_WRK): ==== //depot/projects/valgrind/coregrind/m_syswrap/syscall-x86-freebsd.S#6 (text+ko) ==== @@ -84,7 +84,7 @@ */ /* from vki_arch.h */ -#define VKI_SIG_SETMASK 2 +#define VKI_SIG_SETMASK 3 /* QQQ translate syscall abi conventions */ .globl ML_(do_syscall_for_client_WRK)