From owner-freebsd-net  Sun Aug 20 23:34:14 2000
Delivered-To: freebsd-net@freebsd.org
Received: from info.iet.unipi.it (info.iet.unipi.it [131.114.9.184])
	by hub.freebsd.org (Postfix) with ESMTP id 09D8F37B424
	for <freebsd-net@FreeBSD.ORG>; Sun, 20 Aug 2000 23:34:09 -0700 (PDT)
Received: (from luigi@localhost)
	by info.iet.unipi.it (8.9.3/8.9.3) id IAA19062;
	Mon, 21 Aug 2000 08:35:47 +0200 (CEST)
	(envelope-from luigi)
From: Luigi Rizzo <luigi@info.iet.unipi.it>
Message-Id: <200008210635.IAA19062@info.iet.unipi.it>
Subject: Re: question on sys/net/ip_fw.h
In-Reply-To: <20000820221822.A30286@sofia.csl.sri.com> from Marco Molteni at
 "Aug 20, 2000 10:18:22 pm"
To: Marco Molteni <molter@sofia.csl.sri.com>
Date: Mon, 21 Aug 2000 08:35:47 +0200 (CEST)
Cc: freebsd-net@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL61 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Hi,
yes the comments are obsolete, but because in
3.x and above setsockopt() can handle parms of arbitrary size
and is not limited anymore to MLEN. So the entire comment should
be removed.

	cheers
	luigi
>   * fw_src, fw_dst, fw_smsk, fw_dmsk are always stored in network byte order.
>   * fw_flg and fw_n*p are stored in host byte order (of course).
>   * Port numbers are stored in HOST byte order.
> - * Warning: setsockopt() will fail if sizeof(struct ip_fw) > MLEN (108)
> + * Warning: setsockopt() will fail if sizeof(struct ip_fw) > MLEN
> + * (see sys/mbuf.h).
>   */
> 
> 
> Am I right? Is someone willing to commit the change?
> 
> Thanks
> Marco 
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-net" in the body of the message
> 



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message