From owner-freebsd-stable@freebsd.org Mon Sep 12 16:44:16 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 93474BD802C for ; Mon, 12 Sep 2016 16:44:16 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 7DFBF858 for ; Mon, 12 Sep 2016 16:44:16 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: by mailman.ysv.freebsd.org (Postfix) id 7D5A4BD802B; Mon, 12 Sep 2016 16:44:16 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7D043BD8029 for ; Mon, 12 Sep 2016 16:44:16 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3F5A0857; Mon, 12 Sep 2016 16:44:16 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1bjUL6-000Khb-UX; Mon, 12 Sep 2016 19:44:12 +0300 Date: Mon, 12 Sep 2016 19:44:12 +0300 From: Slawa Olhovchenkov To: Andriy Gapon Cc: Konstantin Belousov , stable@FreeBSD.org Subject: Re: X2APIC support Message-ID: <20160912164412.GS34394@zxy.spb.ru> References: <20160901112724.GX88122@zxy.spb.ru> <20160901114500.GJ83214@kib.kiev.ua> <20160901121300.GZ88122@zxy.spb.ru> <4ba05c00-f737-f562-553d-a7fa59145768@FreeBSD.org> <20160904151415.GE83214@kib.kiev.ua> <20160904162926.GF83214@kib.kiev.ua> <358ed414-9da6-ac29-55fc-6d7be680c2ce@FreeBSD.org> <20160912093905.GP34394@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 16:44:16 -0000 On Mon, Sep 12, 2016 at 04:44:09PM +0300, Andriy Gapon wrote: > On 12/09/2016 12:39, Slawa Olhovchenkov wrote: > > On Sun, Sep 04, 2016 at 08:14:07PM +0300, Andriy Gapon wrote: > > > >> On 04/09/2016 19:29, Konstantin Belousov wrote: > >>> This is possible, of course. But it would not affect "SMP: Added CPU ..." > >>> lines. > >> > >> Well, looking at the code it seems that only if mptable is used, then those > >> lines are expected to correctly identify a BSP. With MADT there is no > >> information to identify the BSP and that is supposed to happen in cpu_mp_start(). > >> > >> > >> static void > >> madt_add_cpu(u_int acpi_id, u_int apic_id, u_int flags) > >> { > >> struct lapic_info *la; > >> > >> /* > >> * The MADT does not include a BSP flag, so we have to let the > >> * MP code figure out which CPU is the BSP on its own. > >> */ > >> ... > >> > >> In other words, those "SMP: Added CPU ..." are truly a cosmetic issue. > >> And it's my guess (just a guess) that BSP LAPIC ID is incorrect in the > >> problematic configuration. > > > > For next day or two I am have new server with same hardware before put > > in prodution. > > Can I do some test for you? > > > > >From my earlier email: > "my guess can be checked by adding a printf to cpu_mp_start() right after > boot_cpu_id assignment". I am not kernel developer: please point what I am need insert and file for edit.