From owner-cvs-all Sat Jan 19 9:34:41 2002 Delivered-To: cvs-all@freebsd.org Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id 1675F37B417; Sat, 19 Jan 2002 09:34:33 -0800 (PST) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g0JHYLg27285; Sat, 19 Jan 2002 17:34:21 GMT (envelope-from mark@grondar.za) Received: from grondar.za (mark@localhost [127.0.0.1]) by grimreaper.grondar.org (8.11.6/8.11.6) with ESMTP id g0JHWGt22692; Sat, 19 Jan 2002 17:32:16 GMT (envelope-from mark@grondar.za) Message-Id: <200201191732.g0JHWGt22692@grimreaper.grondar.org> To: "Andrey A. Chernov" Cc: Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/ftpd ftpd.c References: <20020119163648.GD10976@nagual.pp.ru> In-Reply-To: <20020119163648.GD10976@nagual.pp.ru> ; from "Andrey A. Chernov" "Sat, 19 Jan 2002 19:36:48 +0300." Date: Sat, 19 Jan 2002 17:32:16 +0000 From: Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > None of your patches to pam_opie, pam_unix or ftpd were reviewed by > > anyone with in-depth knowledge of PAM. I'd like you to back them all > > out and submit them to markm and myself for review, along with a > > *detailed* explanation of what you think is wrong and why you think > > your patch is correct. > > 1) I agree that PAM_CRED_ERR may be not the perfect choice and hear for > better altenatives. Do you have a copy of the PAM documentation on writing modules? > 2) Excepting that thing, you already see my patches in the tree. I may > produce diff, if it is needed. We can produce diffs as we have CVS. I have objected to a part of this set of commits on security grounds (with details), Kris has objected on security grounds, DES has objected on technical grounds, and now DES has asked for backout. As DES is the one contracted to fix PAM, and I am the current PAM custodian, I think the next step is pretty obvious. > 3) I already post most detailed explanation considering all possible > variants. I can resend it to you, if you miss it in the thread. Your arguments have been noted, and disagreed with. M -- o Mark Murray \_ FreeBSD Services Limited O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message