From owner-freebsd-hackers@FreeBSD.ORG Wed Oct 14 04:35:23 2009 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32823106566C for ; Wed, 14 Oct 2009 04:35:23 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id D2E348FC12 for ; Wed, 14 Oct 2009 04:35:22 +0000 (UTC) Received: (qmail 4419 invoked by uid 399); 14 Oct 2009 04:35:21 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 14 Oct 2009 04:35:21 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AD55506.4000507@FreeBSD.org> Date: Tue, 13 Oct 2009 21:35:18 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: Doug Barton , hackers@freebsd.org References: <20091011145021.GG36937@acme.spoerlein.net> <4AD3C09B.70801@FreeBSD.org> <20091013070417.GK36937@acme.spoerlein.net> In-Reply-To: <20091013070417.GK36937@acme.spoerlein.net> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: Re: RFC: Big Makefile patch for WARNS settings X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 04:35:23 -0000 Ulrich Spörlein wrote: > The "default" would be the setting inherited by, eg, > src/bin/Makefile.inc. This already has a WARNS=6, are you saying that > debugging stuff under bin/ has been made more difficult by that change? It certainly can be, yes. Although admittedly I don't spend a lot of time debugging stuff under /bin. > Why do we want bin/ to be WARNS-clean and not care about usr.bin/? Red herring. I'd like everything to be as warns-clean as possible, I just disagree that this change will do anything to improve it. > One of the strengths of BSD in general that I have come to love is its > higher consistency compared to most other systems. With WARNS=6 under > bin/ and WARNS=2 under sbin/ this consistency is violated. The thing that you're glossing over is that most of the stuff in /bin is our code, and a lot of the stuff in /usr/[s]bin is contrib code. Thus they actually ARE different. Then of course there is the whole "Foolish consistency ...." issue. >>> There's also a lot of >>> work done by the DragonflyBSD folks which I intend to port peu a peu. >> Can you elaborate on this? What work are you planning to port over, >> and how does it depend on this default WARNS level issue? > > See > http://gitweb.dragonflybsd.org/dragonfly.git?a=search&h=HEAD&st=commit&s=WARNS6 > > It depends in no way on the included WARNS level, but "the big switch" > needs to be done anyway, so why not upfront? I disagree with your assertion that "the big switch needs to be done anyway." My personal preference would be to see first how many things will need overrides (WARNS != 6) before deciding whether it's worth setting a default. hth, Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/