From owner-freebsd-net Thu May 23 13:37:37 2002 Delivered-To: freebsd-net@freebsd.org Received: from mail-out2.apple.com (mail-out2.apple.com [17.254.0.51]) by hub.freebsd.org (Postfix) with ESMTP id 069F537B414; Thu, 23 May 2002 13:37:31 -0700 (PDT) Received: from mailgate1.apple.com (A17-128-100-225.apple.com [17.128.100.225]) by mail-out2.apple.com (8.11.3/8.11.3) with ESMTP id g4NKbUs28852; Thu, 23 May 2002 13:37:30 -0700 (PDT) Received: from scv1.apple.com (scv1.apple.com) by mailgate1.apple.com (Content Technologies SMTPRS 4.2.1) with ESMTP id ; Thu, 23 May 2002 13:36:57 -0700 Received: from [17.219.180.26] (minshallidsl1.apple.com [17.219.180.26]) by scv1.apple.com (8.11.3/8.11.3) with ESMTP id g4NKbT922504; Thu, 23 May 2002 13:37:29 -0700 (PDT) X-Sender: conrad@mail.apple.com Message-Id: In-Reply-To: <20020523111658.N405-100000@def.the.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Thu, 23 May 2002 13:37:26 -0700 To: "Semen A. Ustimenko" , freebsd-net@FreeBSD.ORG From: Conrad Minshall Subject: Re: NFS don't set sopt.sopt_dir sometimes... Maybe sosetopt() should? Cc: freebsd-fs@FreeBSD.ORG Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org At 9:28 PM -0700 5/22/02, Semen A. Ustimenko wrote: >Looks like nfs_socket.c and nfs_syscalls.c lack strings > > sopt.sopt_dir = SOPT_SET; > >when setting TCP_NODELAY and SO_KEEPALIVE. For SO_KEEPALIVE, it doesn't >matter, sosetopt() doesn't examine it, but TCP_NODELAY is actually >ignored. > >Obviously, it's easy to add these lines, but maybe it's better to make >sosetopt() set sopt_dir for callers? This came up with SMB (and NFS) in Darwin. Changing both caller and callee is the robust choice in our case as old loadable kernel module binaries with new kernels will get fixed, and vice-versa. If you have the luxury of not considering out-of-sync kernel loadables then I envy you :) -- Conrad Minshall, conrad@apple.com, 408 974-2749 Apple Computer, Mac OS X Core Operating Systems To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message