From owner-freebsd-current@FreeBSD.ORG  Thu Aug 22 04:04:19 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 9F25D354
 for <current@FreeBSD.org>; Thu, 22 Aug 2013 04:04:19 +0000 (UTC)
 (envelope-from jmg@h2.funkthat.com)
Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7FA442AF9
 for <current@FreeBSD.org>; Thu, 22 Aug 2013 04:04:19 +0000 (UTC)
Received: from h2.funkthat.com (localhost [127.0.0.1])
 by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id r7M44IZJ078520
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
 for <current@FreeBSD.org>; Wed, 21 Aug 2013 21:04:18 -0700 (PDT)
 (envelope-from jmg@h2.funkthat.com)
Received: (from jmg@localhost)
 by h2.funkthat.com (8.14.3/8.14.3/Submit) id r7M44IEX078519
 for current@FreeBSD.org; Wed, 21 Aug 2013 21:04:18 -0700 (PDT)
 (envelope-from jmg)
Date: Wed, 21 Aug 2013 21:04:18 -0700
From: John-Mark Gurney <jmg@funkthat.com>
To: current@FreeBSD.org
Subject: why does buildkernel set COMPILER_TYPE?
Message-ID: <20130822040418.GE94127@funkthat.com>
Mail-Followup-To: current@FreeBSD.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2.3i
X-Operating-System: FreeBSD 7.2-RELEASE i386
X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88  9322 9CB1 8F74 6D3F A396
X-Files: The truth is out there
X-URL: http://resnet.uoregon.edu/~gurney_j/
X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html
X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger?
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2
 (h2.funkthat.com [127.0.0.1]); Wed, 21 Aug 2013 21:04:18 -0700 (PDT)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Aug 2013 04:04:19 -0000

I've noticed that if you do a:
make buildworld WITHOUT_CLANG_IS_CC=YES

and then do a:
make buildkernel

(w/o the WITHOUT_CLANG_IS_CC=YES option)
that it fails...  Apparently instead of letting buildkernel figure out
which compiler it will use, the src/Makefile.inc1 forces COMPILER_TYPE
to be what the options specified instead of using what bsd.compiler.mk
figures out...

Can w/ please fix this?  This isn't the first time I've run into this,
and it's quite anoying.

This simple patch fixes it:
ndex: Makefile.inc1
===================================================================
--- Makefile.inc1       (revision 254546)
+++ Makefile.inc1       (working copy)
@@ -428,7 +428,7 @@
 .endif
 
 # kernel stage
-KMAKEENV=      ${WMAKEENV}
+KMAKEENV=      ${WMAKEENV:NCOMPILER_TYPE=*}
 KMAKE=         ${KMAKEENV} ${MAKE} ${.MAKEFLAGS} ${KERNEL_FLAGS} KERNEL=${INSTKERNNAME}
 
 #

This just removes setting COMPILER_TYPE for the kernel target and lets
the magic in bsd.compiler.mk do it's thing...

Comments?

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."