From owner-svn-ports-all@FreeBSD.ORG Wed Aug 21 16:27:32 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id CF28C83A for ; Wed, 21 Aug 2013 16:27:32 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A18D227B8 for ; Wed, 21 Aug 2013 16:27:32 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id ro12so599077pbb.13 for ; Wed, 21 Aug 2013 09:27:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ireiYCaU+yh7UsyvGfxD1LeNc/D5Fmg2F/G1wQjoNMs=; b=jKrWVUj1ZQSvG55+LYMMPw/5AK+I4hiljjmgvgxnafpZHcA7ZBbfRxPBnavYum4Qqv szufb+YpKMHg/ZeGYIe8lKuaYoYo/0HlzGo+FlIJooOBtf1+uldPNdMyGn42eFehGJJt l47gL7N7tM5o0C7ddjLdkGBNqatqiSoOY8loUkzYCTvQ1D5doEloN5uAI9ABBOfcvkD0 BBrB+xFrAwNiWDssOaSCG6WoWsDDgy52zPDaeUnVYpsDX4iFVORBDz1vtx7C+HSmA5OB RLZuE3gWxlfNQz/ToKflB+t38yWH7OguoHmAx2vX0N0GjVhmtEBBwVu1dyZIg2RvikGe /TQw== X-Gm-Message-State: ALoCoQkAoppUVs1g2YAiaDEubDxdKMqu70txp79sYE9lfEqEIpPrDNqGPNYCSDM+uhlxfPfi3EoF MIME-Version: 1.0 X-Received: by 10.66.190.230 with SMTP id gt6mr10212347pac.31.1377102452323; Wed, 21 Aug 2013 09:27:32 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.70.100.165 with HTTP; Wed, 21 Aug 2013 09:27:32 -0700 (PDT) In-Reply-To: <5214E45B.4030103@marino.st> References: <201308201148.r7KBmYcU083251@svn.freebsd.org> <521359E7.2020008@marino.st> <52135BDE.9070600@marino.st> <20130821012043.GA40499@FreeBSD.org> <5214E45B.4030103@marino.st> Date: Wed, 21 Aug 2013 09:27:32 -0700 X-Google-Sender-Auth: 2H7aF2DwlQH8LaRldiJeeFY4P9I Message-ID: Subject: Re: svn commit: r325041 - head/japanese/eb From: Jason Helfman To: marino@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-ports-head@freebsd.org" , Alexey Dokuchaev , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" , Jason Helfman , Andrej Zverev X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Aug 2013 16:27:32 -0000 On Wed, Aug 21, 2013 at 9:01 AM, John Marino wrote: > On 8/21/2013 17:58, Jason Helfman wrote: > > I thought I was making that clear. > > The PR shouldn't have been committed as is, so it is for the committer > > to resolve the issue. > > To be fair, while I believe there is an issue, I haven't proven it yet. > I also took over the PR, so now it's my responsibility. > > Regards, > John > > Fair enough. What this is doing though is making gettext a build dependency regardless if NLS is selected or not. (nls disabled here) $ make -V PORT_OPTIONS DOCS EXAMPLES IPV6 $ make -V USES gettext perl5 (nls enabled here) $ make -V PORT_OPTIONS DOCS EXAMPLES IPV6 NLS $ make -V USES gettext perl5 However the port doesn't disable NLS if it is not selected. It should conditionally add gettext, as you've pointed out, Unless of course it requires gettext regardless, which I have seen as well. I did built it though, and it looks like it needs gettext regardless, and it does break. http://meatwad.mouf.net/rubick/poudriere/logs/bulk/91amd64-jgh/latest/logs/errors/ja-eb-4.4.3.log And this log is with --disable-nls http://meatwad.mouf.net/rubick/poudriere/logs/bulk/91amd64-jgh/latest/logs/errors/ja-eb-4.4.3.log Sounds like an upstream bug, and when or if ever fixed, uses can be fixed to be conditional. -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve