From owner-svn-src-all@freebsd.org Wed Nov 6 20:40:16 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 540CF1BF8BB for ; Wed, 6 Nov 2019 20:40:16 +0000 (UTC) (envelope-from njm@njm.me.uk) Received: from smtp001-out2.apm-internet.net (smtp001-out.apm-internet.net [85.119.248.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 477dhH294Fz4bwR for ; Wed, 6 Nov 2019 20:40:14 +0000 (UTC) (envelope-from njm@njm.me.uk) Received: (qmail 74614 invoked from network); 6 Nov 2019 20:40:12 -0000 X-APM-Out-ID: 15730728127460 X-APM-Authkey: 18389/1(18389/1) 5 Received: from unknown (HELO meld.njm.me.uk) (90.194.130.32) by smtp001.apm-internet.net with SMTP; 6 Nov 2019 20:40:12 -0000 Received: from triton.njm.me.uk (triton.njm.me.uk [192.168.144.133]) by meld.njm.me.uk (8.15.2/8.15.2) with ESMTP id xA6KeCeH047286; Wed, 6 Nov 2019 20:40:12 GMT (envelope-from njm@njm.me.uk) Received: from localhost (localhost [127.0.0.1]) by triton.njm.me.uk (8.15.2/8.15.2) with ESMTP id xA6KeC21076802; Wed, 6 Nov 2019 20:40:12 GMT (envelope-from njm@njm.me.uk) Date: Wed, 06 Nov 2019 20:40:12 +0000 From: "N.J. Mann" To: Ed Maste , svn-src-all@freebsd.org Subject: Re: svn commit: r354410 - in head/sys: dev/mgb modules/mgb Message-ID: In-Reply-To: <201911061951.xA6JpffX060159@repo.freebsd.org> References: <201911061951.xA6JpffX060159@repo.freebsd.org> X-Mailer: Mulberry/4.0.8 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Rspamd-Queue-Id: 477dhH294Fz4bwR X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of njm@njm.me.uk has no SPF policy when checking 85.119.248.222) smtp.mailfrom=njm@njm.me.uk X-Spamd-Result: default: False [0.46 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.71)[-0.712,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[njm.me.uk]; AUTH_NA(1.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_SPAM_LONG(0.02)[0.016,0]; R_SPF_NA(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[222.248.119.85.list.dnswl.org : 127.0.3.1]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:35259, ipnet:85.119.248.0/21, country:GB]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(0.36)[ipnet: 85.119.248.0/21(1.03), asn: 35259(0.82), country: GB(-0.08)]; FROM_EQ_ENVFROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Nov 2019 20:40:16 -0000 Hi, I cannot comment on the code, but... On Wednesday, November 06, 2019 19:51:41 +0000 Ed Maste wrote: > Author: emaste > Date: Wed Nov 6 19:51:40 2019 > New Revision: 354410 > URL: https://svnweb.freebsd.org/changeset/base/354410 [...] > Added: head/sys/dev/mgb/if_mgb.c > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/sys/dev/mgb/if_mgb.c Wed Nov 6 19:51:40 2019 (r354410) > @@ -0,0 +1,1634 @@ > +/*- > + * SPDX-License-Identifier: BSD-2-Clause > + * > + * Copyright (c) 2019 The FreeBSD Foundation, Inc. > + * > + * This driver was written by Gerald ND Aryeetey > + * under sponsorship from the FreeBSD Foundation. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * 1. Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * 2. Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in the > + * documentation and/or other materials provided with the distribution. > + * > + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > + * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS > + * OR SERVICES; LOSS OF USE DATA, OR PROFITS; OR BUSINESS INTERRUPTION) > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > + * SUCH DAMAGE. > + */ > +#include > +__FBSDID("$FreeBSD$"); > + > +/* > + * Microchip LAN7430/LAN7431 PCIe to Gigabit Ethernet Controller driver. > + * > + * Product information: > + * LAN7430 https://www.microchip.com/wwwproducts/en/LAN7430 > + * - Integrated IEEE 802.3 compliant PHY > + * LAN7431 https://www.microchip.com/wwwproducts/en/LAN7431 > + * - RGMII Interface > + * > + * This driver uses the iflib interface and the default 'ukphy' PHY driver. > + * > + * UNIMPLEMENTED FEATURES > + * ---------------------- > + * A number of features supported by LAN743X device are not yet implemented in > + * this driver: > + * > + * - Multiple (up to 4) RX queues support > + * - Just needs to remove asserts and malloc multiple `rx_ring_data` > + * structs based on ncpus. > + * - RX/TX Checksum Offloading support > + * - VLAN support > + * - Recieve Packet Filtering (Multicast Perfect/Hash Address) support ^^^^^^^ Should be Receive (and all the later ones). Cheers, Nick. --