Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 31 Oct 2011 20:02:11 +0000 (UTC)
From:      Xin LI <delphij@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r226969 - stable/9/sys/dev/tws
Message-ID:  <201110312002.p9VK2BQ7032019@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: delphij
Date: Mon Oct 31 20:02:11 2011
New Revision: 226969
URL: http://svn.freebsd.org/changeset/base/226969

Log:
  MFC r226887:
  
  Don't expose a constant array into global namespace.
  
  Reported by:	Ruslan Yakovlev <quazi bk ru> via yongari
  Approved by:	re (kib)

Modified:
  stable/9/sys/dev/tws/tws_services.c
  stable/9/sys/dev/tws/tws_services.h
Directory Properties:
  stable/9/sys/   (props changed)

Modified: stable/9/sys/dev/tws/tws_services.c
==============================================================================
--- stable/9/sys/dev/tws/tws_services.c	Mon Oct 31 16:05:33 2011	(r226968)
+++ stable/9/sys/dev/tws/tws_services.c	Mon Oct 31 20:02:11 2011	(r226969)
@@ -53,7 +53,7 @@ struct tws_sense *tws_find_sense_from_mf
 
 
 
-struct error_desc array[] = {
+static struct error_desc array[] = {
     { "Cannot add sysctl tree node", 0x2000, ERROR,
        "%s: (0x%02X: 0x%04X): %s:\n", "ERROR" },
     { "Register window not available", 0x2001, ERROR,

Modified: stable/9/sys/dev/tws/tws_services.h
==============================================================================
--- stable/9/sys/dev/tws/tws_services.h	Mon Oct 31 16:05:33 2011	(r226968)
+++ stable/9/sys/dev/tws/tws_services.h	Mon Oct 31 20:02:11 2011	(r226969)
@@ -114,7 +114,6 @@ struct error_desc {
     char *error_str;
 };
 
-extern struct error_desc array[];
 /* ----------- q services ------------- */
 
 #define TWS_FREE_Q        0



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110312002.p9VK2BQ7032019>