Date: Mon, 2 Aug 1999 10:13:48 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: Alfred Perlstein <bright@rush.net> Cc: hackers@FreeBSD.ORG Subject: Re: confusion about nfsm_srvmtofh bad behavior? Message-ID: <199908021713.KAA14239@apollo.backplane.com> References: <Pine.BSF.3.96.990802113034.20420m-100000@cygnus.rush.net>
next in thread | previous in thread | raw e-mail | index | archive | help
:The whole file needs some **** documentation. :) :I stared at that for so long wondering why the heck it was doing that. NFS is the worst-documented code in the kernel, VFS is second-worst. Without commit privs, documenting existing code eats too much of my time I'm afraid. With commit privs I tended to document as I went. :Is there a chance you could give this some of your famous regression :testing? :... :http://big.endian.org/~bright/freebsd/patches/nfsm_subs.diff Lemme look at the patch.... hmm. The patch looks reasonable, I will test it as soon as I finish running the buildworld test on localhost NFS mounts. My source tree is getting a little messy. We have madvise() broken open too. Hopefully we will be able to get that committed soon. -Matt Matthew Dillon <dillon@backplane.com> :i'd rather get rid of the extra copying going on and since :previously it was filled with garbage from the rest of the RPC :structure i don't think it's nessesary. : :-Alfred Perlstein - [bright@rush.net|bright@wintelcom.net] :systems administrator and programmer To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199908021713.KAA14239>