From owner-svn-ports-all@freebsd.org Tue Nov 13 09:44:09 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2B654110C97B; Tue, 13 Nov 2018 09:44:09 +0000 (UTC) (envelope-from makc@freebsd.org) Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.issp.ac.ru", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 58AEC7BF1A; Tue, 13 Nov 2018 09:44:08 +0000 (UTC) (envelope-from makc@freebsd.org) Received: from mail-vs1-f41.google.com [209.85.217.41:39899] (HELO/EHLO mail-vs1-f41.google.com, authenticated with PLAIN) by mail.issp.ac.ru with ESMTPSA/inet id wAD9hwvw041708 (using TLSv1.2, with cipher ECDHE-RSA-AES128-GCM-SHA256 (128 bits), verified FAIL) Tue, 13 Nov 2018 12:43:59 +0300 (MSK) Received: by mail-vs1-f41.google.com with SMTP id h78so6863574vsi.6; Tue, 13 Nov 2018 01:43:59 -0800 (PST) X-Gm-Message-State: AGRZ1gIiTddZ9ErsKoZ2UPls9XNXpt73jJEZShnoS7tnCWrM1OrZOVtB jlUt7T67toVRTzgRsvsPeo0xccMY3YO/dxbbTD0= X-Google-Smtp-Source: AJdET5f9mPQX4dg62Mx99AuB84cE7ESOEG4Pn5ZQIiJCs0teoFaJXQKe/MbhXsCyrlLgdQDtj0Mdh/zL5AWlRny33Co= X-Received: by 2002:a67:67c4:: with SMTP id b187mr2007440vsc.140.1542102237876; Tue, 13 Nov 2018 01:43:57 -0800 (PST) MIME-Version: 1.0 References: <201811111145.wABBjKcf027649@repo.freebsd.org> <5zx3-zver-wny@FreeBSD.org> <4618826.YNO7O01DYZ@mercury.ph.man.ac.uk> <20181112183423.xmp67tjjghceot75@atuin.in.mat.cc> In-Reply-To: <20181112183423.xmp67tjjghceot75@atuin.in.mat.cc> From: Max Brazhnikov Date: Tue, 13 Nov 2018 09:43:46 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r484686 - head/net-im/telegram-desktop To: mat@freebsd.org Cc: jbeich@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, henry.hu.sh@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 58AEC7BF1A X-Spamd-Result: default: False [-102.92 / 200.00]; ALLOW_DOMAIN_WHITELIST(-100.00)[freebsd.org]; TO_DN_NONE(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[cached: mx66.freebsd.org]; NEURAL_HAM_SHORT(-0.81)[-0.806,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:42317, ipnet:77.236.32.0/20, country:RU]; IP_SCORE(-0.00)[country: RU(-0.01)]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.34.236.77.list.dnswl.org : 127.0.10.0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 09:44:09 -0000 On Mon, 12 Nov 2018 at 18:34, Mathieu Arnold wrote: > > On Sun, Nov 11, 2018 at 11:59:48AM +0000, Max Brazhnikov wrote: > > On =D0=B2=D0=BE=D1=81=D0=BA=D1=80=D0=B5=D1=81=D0=B5=D0=BD=D1=8C=D0=B5, = 11 =D0=BD=D0=BE=D1=8F=D0=B1=D1=80=D1=8F 2018 =D0=B3. 11:49:16 UTC Jan Beich= wrote: > > > Max Brazhnikov writes: > > > > @@ -82,6 +82,7 @@ post-patch: > > > > ${FILESDIR}/gyp-patches | \ > > > > ${PATCH} -z .bak -s) > > > > > > > > @${ECHO} "#define FREEBSD_QT_PLUGINDIR \"${QT_PLUGINDIR}\"" > > > > > ${WRKSRC}/Telegram/SourceFiles/FREEBSD_QT_PLUGINDIR.h> > > > > + ${SED} -i -e "/Icon=3D/s|telegram|${PORTNAME}|" > > > > ${WRKSRC}/lib/xdg/telegramdesktop.desktop > > > Why ${SED} -i instead of ${REINPLACE_CMD}? > > > > For sake of consistency with the rest of the file. I leave it to mainta= iner. > > The reason we have committers and not a simple script that commits every > patch that applies in is so that people who know better (the committers, > you, Jan, me) fix submissions from maintainers to match our policies and > way of doing things. > > Now, the Makefile is consistenly bad, that is for sure. Sorry, folks. I promise to take next PR for this port and make it decent :)