From owner-svn-src-head@FreeBSD.ORG Fri May 1 16:31:18 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 018A1696; Fri, 1 May 2015 16:31:18 +0000 (UTC) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AF5F81E01; Fri, 1 May 2015 16:31:17 +0000 (UTC) Received: from slw by zxy.spb.ru with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1YoDqG-000GiD-Ez; Fri, 01 May 2015 19:31:08 +0300 Date: Fri, 1 May 2015 19:31:08 +0300 From: Slawa Olhovchenkov To: Gleb Smirnoff Cc: John Baldwin , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r282280 - in head/sys/dev: e1000 ixgbe ixl Message-ID: <20150501163108.GZ1394@zxy.spb.ru> References: <201504301823.t3UINd74073186@svn.freebsd.org> <20150430232736.GB546@FreeBSD.org> <1998053.shmPH6saZj@ralph.baldwin.cx> <20150501135134.GC546@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150501135134.GC546@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 May 2015 16:31:18 -0000 On Fri, May 01, 2015 at 04:51:34PM +0300, Gleb Smirnoff wrote: > On Fri, May 01, 2015 at 09:11:54AM -0400, John Baldwin wrote: > J> > On Thu, Apr 30, 2015 at 06:23:39PM +0000, John Baldwin wrote: > J> > J> Author: jhb > J> > J> Date: Thu Apr 30 18:23:38 2015 > J> > J> New Revision: 282280 > J> > J> URL: https://svnweb.freebsd.org/changeset/base/282280 > J> > J> > J> > J> Log: > J> > J> Various fixes to the stats in igb(4), ixgbe(4), and ixl(4). > J> > J> - Use hardware counters for ifnet stats in igb(4) when possible. This > J> > J> ensures these stats include packets that bypass the regular stack via > J> > J> netmap. > J> > J> - Don't derefence values off the end of the igb(4) VF stats structure. > J> > J> Instead, add a dedicated if_get_counter method for igb(4) VF interfaces. > J> > J> - Report missed packets on igb(4) as input queue drops rather than an > J> > J> input error. > J> > J> - Report bug_ring drop counts as output queue drops for igb(4) and ixgbe(4). > J> > J> - Export the buf_ring drop stats for individual rings via sysctl on > J> > J> ixgbe(4).^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > J> > ^^^^^^^^^ > J> > > J> > While you are here, let me remind you about this plan: > J> > > J> > https://lists.freebsd.org/pipermail/svn-src-head/2014-October/063575.html > J> > > J> > We can prototype the API to userland now, write down a utility that uses > J> > it, or add the functionality to an existing utility. And start with Intel > J> > drivers, that seem to be most interested in extra stats. > J> > J> So the importaing thing here is that if_get_counter() is still doing > J> per-ifnet stats. The stat you underlined above is per-queue instead. > J> We well need more explicitly knowledge of queues outside of drivers > J> and in the stack itself to support a generic framework for per-queue > J> stats. > > This depends on how generic we want the API to be. Of course, we can add > an extra argument to if_get_counter(). > > However, if we don't expect the number of queues to exceed a reasonable > number of 255 :), we can fit the functionality into existing API. > We can keep the queue number in the highest 8 bits of the ift_counter > parameter. In case of hardware-assist NIC emulation numbers may be rise: x710 have 1536 queue per port.