From nobody Sat Mar 23 11:30:03 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V1xnR6zS7z5FDpc for ; Sat, 23 Mar 2024 11:30:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V1xnR4xBVz4mHK for ; Sat, 23 Mar 2024 11:30:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711193403; a=rsa-sha256; cv=none; b=b/JORrIUSH/C4EG0cfLaNKFRmDEboseJpxuem8/eSr4Ae3Q7FpT00vcIN2+GaMgXZ7n5TQ Lgcs4RCJX/x/0GYygHc5gLaEeTTS03ZLMOqfzdu74uIyvT7AE06DBTXC3JmZiaJOvOGy23 C1kfR6ZwwhU6gAJCDh7emBSNorpSREc0chhZvql+AWEQycMEuNOT5hsFrbYK317WR17iA2 9BtFoAwUyInIdDAWCLEWsAshppqngOdr0DCY/xRcds7D8KVdP+imlRKUghK26Kgmy02K7e TUwRtxx6WH0BK4trhoqaU51Ds98Ke+tqo8N4+ecXBzIqrasna9FM7pwEwaZPNw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711193403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R+nhz/jUYoDronTJL+N4FlTZq6OpnK/oGCDjfAzDvpc=; b=RzwB54WDOpWrQdLeLRQHJziPtgrRThwUheZxb5MLiAxCnkz/Ur/Wr/1MO4vvn+OUo3vxAe 9vlF+1Zy4hFLhoG7RjiFL4E7k/taidRIZ/Lw8ApHci77IgNRlJBAaXIsdscsTkzlCnqpWD e967Er2xC2Mx8tfEHwpelHsLO7AuJ5jynKARB5pVNFy4OKBulQNBO+npBUt8pcgDa9qj1y 5SJQkFtzKwK9llO45E0qh2gVugW3s+Fd+ASHUYFcp7bbnRSTVPxQzcRq13ywE+B9wyj1xk Rm4Qm4Ihwd5pnZYgKTW4GEUyfIMVp/umK/ZF3BNsaw+yRJpGU1yzpXiJfPYOsw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4V1xnR4RqLzml6 for ; Sat, 23 Mar 2024 11:30:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 42NBU3Vo035532 for ; Sat, 23 Mar 2024 11:30:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 42NBU3cI035531 for ports-bugs@FreeBSD.org; Sat, 23 Mar 2024 11:30:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 277455] bsd.port.mk: Add __MAKE_CONF=${NONEXISTENT} to WRK_ENV Date: Sat, 23 Mar 2024 11:30:03 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tijl@FreeBSD.org X-Bugzilla-Flags: exp-run+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277455 --- Comment #5 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dd7511b9d00742c3e2d57c6c03718c4a= 6f4cd3e72 commit d7511b9d00742c3e2d57c6c03718c4a6f4cd3e72 Author: Tijl Coosemans AuthorDate: 2024-02-29 21:11:00 +0000 Commit: Tijl Coosemans CommitDate: 2024-03-23 11:19:32 +0000 Mk/bsd.port.mk: Add __MAKE_CONF=3D${NONEXISTENT} to WRK_ENV And remove it from individual ports. Use WRK_ENV in custom build commands where necessary. FreeBSD make(1) includes /usr/share/mk/sys.mk and that includes /etc/make.conf if it exists. This happens when you run make in a port directory but it also happens when the upstream build system uses make. This commit disables make.conf inclusion in the latter case because users can define variables like CFLAGS in make.conf that override ports framework variables and this can cause problems that are difficult to diagnose. If there are any build customisations made through make.conf that stop working because of this commit then they should be made available by the ports tree through some mechanism, e.g. an option in a port. Some ports were picking up variables from Poudriere make.conf and required fixes: - astro/wmspaceweather x11-clocks/wmcalclock: Add OPSYS to MAKE_ENV. - games/zhlt: Add ARCH to MAKE_ENV. - graphics/tachyon: Upstream ARCH is not ports tree ARCH. Set ALL_TARGET=3Dbsd so upstream ARCH is defined correctly. Enable multi-threading support while here. PR: 277455 Exp-run by: antoine Mk/bsd.port.mk | 3 ++- archivers/libcabinet/Makefile | 2 +- astro/wmspaceweather/Makefile | 1 + devel/libpdel/Makefile | 2 +- devel/libshhmsg/Makefile | 2 +- devel/libxalloc/Makefile | 2 +- devel/linux_libusb/Makefile | 14 +++++++------- emulators/vmw/Makefile | 2 +- finance/libstocks/Makefile | 6 +++--- games/libshhcards/Makefile | 2 +- games/zhlt/Makefile | 1 + graphics/tachyon/Makefile | 10 ++++++---- graphics/tachyon/files/patch-Makefile (gone) | 11 ----------- graphics/tachyon/files/patch-src_threads.c (new) | 11 +++++++++++ graphics/tachyon/files/patch-src_threads.h (new) | 11 +++++++++++ graphics/tachyon/files/patch-src_trace.c (new) | 11 +++++++++++ graphics/tachyon/files/patch-unix_Make-arch (new) | 18 ++++++++++++++++++ lang/lua51/Makefile | 8 -------- lang/lua52/Makefile | 8 -------- lang/lua53/Makefile | 8 -------- lang/lua54/Makefile | 8 -------- mail/dma/Makefile | 3 +-- mail/spamilter/Makefile | 1 - math/libmissing/Makefile | 9 +++++---- math/linpack/Makefile | 2 +- ports-mgmt/dialog4ports/Makefile | 2 +- sysutils/dirdiff/Makefile | 5 ----- sysutils/pfstat/Makefile | 1 - sysutils/pftop/Makefile | 1 - x11-clocks/wmcalclock/Makefile | 1 + 30 files changed, 86 insertions(+), 80 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=