From owner-svn-src-head@freebsd.org Fri Dec 30 20:34:48 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC85AC984C8; Fri, 30 Dec 2016 20:34:48 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from st11p00im-asmtp004.me.com (st11p00im-asmtp004.me.com [17.172.80.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B2986127C; Fri, 30 Dec 2016 20:34:48 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from process-dkim-sign-daemon.st11p00im-asmtp004.me.com by st11p00im-asmtp004.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OJ000N00JJJIR00@st11p00im-asmtp004.me.com>; Fri, 30 Dec 2016 19:34:41 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mac.com; s=4d515a; t=1483126481; bh=mDjEU4W4XaCOcPUfmRQ77sfklHMrSJLSimHeMlsGWAI=; h=Date:Subject:From:To:Message-id:MIME-version:Content-type; b=a0N2I+Tl7e6441mxk8CNgo0qnemoddhuiXiB3pU9iED+f+u4y1yw7jE9JgaLBlMTR x4tPKknxODlGkog7BJ7KMdLgv5ofd0Pbsd7rjIJICsLFid3lm5y45WPeRECl8iTF4a rOs/v8Z+PkbZSrBHQn8HpPIHyrioAzF+DoZnJDs6dPBRfpZOOq8/yio9zJlsly3iv+ b2fUcoieGKCwKgfIN29BR5rZ1c9k+zzghvVUGUSssD43QitFAfhep8qOkX7saIsT/U I9qE40M4JARG00Flj8qilc0sqK/DsbBK9q4XQNl77lbvu1f1AC4wj3FAQrlNZAEMFj 2R89oRTTUYdsA== Received: from [10.0.0.7] (c-73-6-177-70.hsd1.tx.comcast.net [73.6.177.70]) by st11p00im-asmtp004.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) with ESMTPSA id <0OJ0000VMJPQJJ20@st11p00im-asmtp004.me.com>; Fri, 30 Dec 2016 19:34:40 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-30_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1034 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1603290000 definitions=main-1612300305 User-Agent: Microsoft-MacOutlook/f.1d.0.161209 Date: Fri, 30 Dec 2016 13:34:38 -0600 Subject: Re: svn commit: r310789 - head/lib/libpam/static_libpam From: Ravi Pokala Sender: "Pokala, Ravi" To: Ed Maste Cc: Alexander Kabaev , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-id: Thread-topic: svn commit: r310789 - head/lib/libpam/static_libpam References: <201612292130.uBTLUqus011628@repo.freebsd.org> <1A7F0D4F-1F4D-4885-B7E9-F764D4FA72BF@panasas.com> In-reply-to: MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2016 20:34:49 -0000 -----Original Message----- > From: on behalf of Ed Maste > Date: 2016-12-30, Friday at 07:39 > To: Ravi Pokala > Cc: Alexander Kabaev , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" > Subject: Re: svn commit: r310789 - head/lib/libpam/static_libpam > > On 29 December 2016 at 19:59, Ravi Pokala wrote: >> >> I'm a little confused - the original version had to have had a compile-only step to generate the object first, before running the link-only operation against the object. The new code replaces the link-only operation with a compile+link operation. Shouldn't the pre-existing compile-only operation be removed, since the new compile+link operation supersedes it? > > Hi Ravi, > > This change: > >>> - ${LD} -o ${.TARGET} -r --whole-archive ${.ALLSRC} >>> + ${CC} -nostdlib ${CFLAGS} -o ${.TARGET} -r -Wl,--whole-archive ${.ALLSRC} > > is not actually compiling, it's just invoking the compiler driver to > in turn invoke the linker. The input in ${.ALLSRC} is still a > collection of object files. Ahhh! My knowledge of `make' is terrible, so I thought ${.ALLSRC} must have been referring to actual source files in some non-obvious way. I also thought some special flag would be needed when passing an object file to the compiler, rather than a source file. Combine those two, and there was my problem. Thanks for clarifying! -Ravi (rpokala@)