From owner-cvs-all@FreeBSD.ORG  Thu Feb 12 08:37:12 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A369016A4CE; Thu, 12 Feb 2004 08:37:12 -0800 (PST)
Received: from kientzle.com (h-66-166-149-50.SNVACAID.covad.net
	[66.166.149.50])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 234D343D1F; Thu, 12 Feb 2004 08:37:12 -0800 (PST)
	(envelope-from kientzle@acm.org)
Received: from acm.org ([66.166.149.54])
	by kientzle.com (8.12.9/8.12.9) with ESMTP id i1CGb8kX024173;
	Thu, 12 Feb 2004 08:37:08 -0800 (PST)
	(envelope-from kientzle@acm.org)
Message-ID: <402BABB1.7060501@acm.org>
Date: Thu, 12 Feb 2004 08:37:05 -0800
From: Tim Kientzle <kientzle@acm.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20031006
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: juli mallett <jmallett@FreeBSD.ORG>
References: <200402120411.i1C4Bf8U036349@repoman.freebsd.org>
	<xzpznbodbo6.fsf@dwp.des.no> <20040212075852.GA93983@FreeBSD.org>
In-Reply-To: <20040212075852.GA93983@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
cc: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>
cc: Tim Kientzle <kientzle@FreeBSD.ORG>
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
cc: cvs-src@FreeBSD.ORG
Subject: Re: cvs commit: src/lib/libarchive Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: kientzle@acm.org
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Feb 2004 16:37:12 -0000

* Dag-Erling Smørgrav <des@des.no> [ Date: 2004-02-12 ]
  	[ w.r.t. Re: cvs commit: src/lib/libarchive Makefile ]
>Tim Kientzle <kientzle@FreeBSD.org> writes:
>
>>  Log:
>>  libarchive itself is now completely clean at WARNS=10 on all architectures.
>>  
>>  Unfortunately, the stock zlib.h is not:
>>    line 885: 'err' parameter shadows global 'err' definition from <err.h>
>
>This is trivial to fix, if we're willing to take zlib.h off the vendor
>branch or manage to convince Gailly to take our patch.

Taking zlib.h off the vendor branch is a decision
I'll leave to Peter, who has been maintaining our
zlib import and will probably suffer the consequences
at the next import.

Convincing Gailly to take our patch is a good idea, but
one that will take a while to implement.  (Especially
since we're several versions behind his current zlib work.)

juli mallett wrote:
> Personally, I'm against prototype declarations in headers being
> warning checked for parameter names, even moreso for headers not
> included within the headers in question.

My personal preference has always been to comment the names
in prototype declarations, e.g.:

int foo(int /* err */);

That way:
   a) The name is there to document the parameter
   b) You avoid problems with over-zealous compiler
      warnings, macro expansions, etc.

"Fixing" the compiler is certainly an approach, but there
are a lot of compilers out there and we can't fix them all.  ;-)

Tim