From owner-freebsd-current@freebsd.org Tue Feb 2 06:50:17 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5C338528539 for ; Tue, 2 Feb 2021 06:50:17 +0000 (UTC) (envelope-from kaduk@mit.edu) Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DVFn51rbvz4YQ3; Tue, 2 Feb 2021 06:50:16 +0000 (UTC) (envelope-from kaduk@mit.edu) Received: from kduck.mit.edu ([24.16.140.251]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 1126oADR021573 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 2 Feb 2021 01:50:15 -0500 Date: Mon, 1 Feb 2021 22:50:10 -0800 From: Benjamin Kaduk To: Rick Macklem Cc: FreeBSD CURRENT , Jung-uk Kim Subject: Re: openssl in head returning "certificate expired" when it has not expired Message-ID: <20210202065010.GR21@kduck.mit.edu> References: <20210202004849.GJ21@kduck.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4DVFn51rbvz4YQ3 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2021 06:50:17 -0000 On Tue, Feb 02, 2021 at 03:48:06AM +0000, Rick Macklem wrote: > Benjamin Kaduk wrote: > >On Tue, Feb 02, 2021 at 12:46:25AM +0000, Rick Macklem wrote: > >> I've recently been testing the daemons that do the > >> non-application data stuff for nfs-over-tls with the > >> openssl in head. > >> > >> These daemons work fine with both ports/security/openssl (openssl-1.1.1h) > >> and ports/security/openssl-devel (openssl3-alpha). > >> > >> However, when linked to the openssl in head, the basic handshake > >> and KTLS works, but the peer certificate from the client is reported > >> as expired by SSL_get_verify_result(), although it is still valid. > >> I added some debug output and the "notAfter" field of the > >> certificate looks correct, so the certificate doesn't seem to be > >> corrupted. > >> > >> I tried backporting the changes in crypto/x509 in head back > >> into ports/security/openssl and it still worked, so those changes > >> do not seem to have caused the problem. > >> There are several differences in the configured options, but I cannot > >> see any other differences between ports/security/openssl and > >> what is in head that could cause this. > >> (The options that differ seem related to old encryption types, etc.) > >> > >> Any other ideas for tracking this down? > > > >Is it perhaps related to https://github.com/openssl/openssl/issues/14036 ? > Well, it is definitely due to a change in behaviour between 1.1.1h and 1.1.1i. > I notices that ports/security/openssl has been upgraded to 1.1.1i and it > exhibits the "expired" behaviour. > > However, in my case, the certificate has not expired. > The notAfter date is in 2022, but SSL_get_verify_results() returns > X509_V_ERR_CERT_HAS_EXPIRED. Is there an expired CA in the chain? I suppose that reverting the commit from https://github.com/openssl/openssl/pull/11359 (linked from the issue) would probably be pretty easty to check. -Ben