Date: Fri, 17 Jan 2003 03:45:41 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Mike Barcroft <mike@FreeBSD.org> Cc: "M. Warner Losh" <imp@bsdimp.com>, <johan@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/lib/libc/stdlib realpath.3 realpath.c src/bin/realpath realpath.c Message-ID: <20030117033631.F3152-100000@gamplex.bde.org> In-Reply-To: <20030116051916.E58850@espresso.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 16 Jan 2003, Mike Barcroft wrote:
> M. Warner Losh <imp@bsdimp.com> writes:
> > In message: <20030115183943.D58850@espresso.q9media.com>
> > Mike Barcroft <mike@FreeBSD.org> writes:
> > : Hmm, I thought it was more complicated than this. IIRC, PATH_MAX
> > : isn't necessarily available at compile-time, so it needs more
> > : complications to conform to POSIX in the case where PATH_MAX isn't
> > : defined. Portablility might not be important, in which case it
> > : isn't clear why we would change from MAXPATHLEN to PATH_MAX or vice
> > : versa.
> >
> > I made this change because PATH_MAX is more posixly correct than
> > MAXPATHLEN and has a better definition. It only handles the case
> > where PATH_MAX is a compile time constant, or when you are using gcc
> > extensions that allow one to allocate memory on the fly.
>
> Fair enough.
Only {PATH_MAX} has a better definition, but we use PATH_MAX. gcc
extensions don't handle the case where PATH_MAX is not a compile time
constant. "char wbuf[PATH_MAX];" doesn't compile if PATH_MAX is not
defined. "char wbuf[sysconf(_SC_PATH_MAX)];" would fail to handle the
cases where sysconf() returns an error.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030117033631.F3152-100000>