From owner-cvs-user Fri Aug 25 23:50:24 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id XAA23785 for cvs-user-outgoing; Fri, 25 Aug 1995 23:50:24 -0700 Received: from grunt.grondar.za (grunt.grondar.za [196.7.18.129]) by freefall.FreeBSD.org (8.6.11/8.6.6) with ESMTP id XAA23761 ; Fri, 25 Aug 1995 23:50:02 -0700 Received: from grumble.grondar.za (grumble.grondar.za [196.7.18.130]) by grunt.grondar.za (8.6.12/8.6.9) with ESMTP id IAA05108; Sat, 26 Aug 1995 08:49:54 +0200 Received: from localhost (localhost [127.0.0.1]) by grumble.grondar.za (8.6.11/8.6.9) with SMTP id IAA25109; Sat, 26 Aug 1995 08:49:53 +0200 Message-Id: <199508260649.IAA25109@grumble.grondar.za> X-Authentication-Warning: grumble.grondar.za: Host localhost didn't use HELO protocol To: Bruce Evans cc: gibbs@freefall.FreeBSD.org, markm@freefall.FreeBSD.org, CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c Date: Sat, 26 Aug 1995 08:49:53 +0200 From: Mark Murray Sender: cvs-user-owner@FreeBSD.org Precedence: bulk > >I don't view this as a cleanup at all. It makes unnecessary conflicts with > >the original code and makes it more difficult to incomperate patches from > >outside sources. > > I agree. > > However, if the original really didn't have an explicit return type, then > there is no way to get it through gcc -Wall -Wreally-all without changing > the key line of the declaration. There are very many functions that did not have return types or any other kind of useful info. Doing all this exposed a number of buglets. (BTW, I have not used -Wreally-all. Didn't think it was worth _that_ much trouble) M -- Mark Murray 46 Harvey Rd, Claremont, Cape Town 7700, South Africa +27 21 61-3768 GMT+0200 Finger mark@grumble.grondar.za for PGP key