From nobody Thu Sep 21 13:53:33 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rrxgx4j4Kz4vBCs for ; Thu, 21 Sep 2023 13:53:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rrxgx37PLz3ZP7 for ; Thu, 21 Sep 2023 13:53:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695304413; a=rsa-sha256; cv=none; b=enmNGTNbU5libk7WHaKkTlQPtdGqvOLQyc6PapJyNkgnHDsVWnozAG4IqjeHe/TXPnjZQi OWyxQP9Q+6cv5IWNRlqO0wGnNjkReLMaPl68S8KjvODtglH4MravesnNKPgJZcWAw89Paw 3XiN61wYqOVdvLwfAJzbQA2z1hbcs/SSG1b2XNKohpRGN51Fr+cgL+VfU5dFAaUKcNbUGe 5BJIB/IEpm5q2yd8H+TaGmXaKPjjzipyBAvWvSCko0W/HCGiUH8a7wcsdDh/g7dryA9e1p qCWKScPWYMuU+fVOtNdcx5dd2L2/GEQ3DpYKcVMpnhPGObZzJn5zH3xl5IINMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695304413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EPqXPxV8pwLar9K9BoxL/D6sRqVFmwGxW3X6OiQx3Ik=; b=eHZQATjNFn05ApqlOKztLWQfNfoCpp9YQhQRBuvQhF7U+r+hcS8E0gU/1HVdYp/M2vwrZ5 G8W0TxCQZwTxIu/+rK9gULxqWA7e69FG0dy8+NlvcKN5+35L7EFtOI98ZG+haos1eMUlXV HGwGvGrhAE9kAou9lJzNp6/QNq7/O5RRYu0Hgb3+gUCv7PgqToTYvZIMQtWDsGkfb3iD1K 2rfzGEZDaF3WKqenqmdItlK9xaOveuKK+rbyAvVLYrUIC4+MMPcFaT8lcl+RwKXONDN2qU wlbfEKHvLzjOT6SsvZAerP+2HzNmvFWEOpwB/yXbig1IuzZxhMRwOsAQngtnAQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rrxgx2DWvzgws for ; Thu, 21 Sep 2023 13:53:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38LDrXqJ004719 for ; Thu, 21 Sep 2023 13:53:33 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38LDrX6k004718 for ports-bugs@FreeBSD.org; Thu, 21 Sep 2023 13:53:33 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 270035] Developer checks for stage-qa emit false positives re: USES= ssl with OpenSSL ports Date: Thu, 21 Sep 2023 13:53:33 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fernape@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270035 --- Comment #3 from Fernando Apestegu=C3=ADa --- Created attachment 245093 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D245093&action= =3Dedit Patch for qa.sh qa.sh checks the library requirements for every elf executable and .so file= in the staging directory. If readelf(1) reports a NEEDED libcrypto.so or NEEDED libssl.so for the executable or .so file, then it warns about USES=3Dssl if= not found in the port's Makefile. In the case of security/libressl, qa.sh detects these libraries needed: Warning: (0x0000000000000001 NEEDED Shared library: [libcrypto.so.50]) in /usr/local/bin/ocspcheck Warning: (0x0000000000000001 NEEDED Shared library: [libssl.so.53]) in /usr/local/bin/openssl Warning: (0x0000000000000001 NEEDED Shared library: [libcrypto.so.50]) in /usr/local/bin/openssl Warning: (0x0000000000000001 NEEDED Shared library: [libcrypto.so.50]) in /usr/local/lib/libssl.so.53.0.2 I think if the port itself provides the libcrypto.so or libssl.so libraries, then we shouldn't check for the USES=3Dssl. This patch tries to address this case. It seems to work. It still warns for other ports if they link against those libraries, the libraries are not provided by the port itself and USES=3Dssl is not used. Would you give it a try? --=20 You are receiving this mail because: You are on the CC list for the bug.=