From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Dec 20 16:20:02 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0EF141065670 for ; Sat, 20 Dec 2008 16:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DAE148FC18 for ; Sat, 20 Dec 2008 16:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mBKGK1Pn045676 for ; Sat, 20 Dec 2008 16:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mBKGK1c9045675; Sat, 20 Dec 2008 16:20:01 GMT (envelope-from gnats) Resent-Date: Sat, 20 Dec 2008 16:20:01 GMT Resent-Message-Id: <200812201620.mBKGK1c9045675@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ulrich Spoerlein Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50253106564A; Sat, 20 Dec 2008 16:11:57 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from acme.spoerlein.net (cl-43.dus-01.de.sixxs.net [IPv6:2a01:198:200:2a::2]) by mx1.freebsd.org (Postfix) with ESMTP id BDBA48FC16; Sat, 20 Dec 2008 16:11:56 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from roadrunner.spoerlein.net (e180177211.adsl.alicedsl.de [85.180.177.211]) by acme.spoerlein.net (8.14.2/8.14.2) with ESMTP id mBKGBrtr027831 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 20 Dec 2008 17:11:55 +0100 (CET) (envelope-from uspoerlein@gmail.com) Received: from roadrunner.spoerlein.net (localhost [127.0.0.1]) by roadrunner.spoerlein.net (8.14.3/8.14.3) with ESMTP id mBKG7bRQ004022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 20 Dec 2008 17:07:37 +0100 (CET) (envelope-from uqs@roadrunner.spoerlein.net) Received: (from uqs@localhost) by roadrunner.spoerlein.net (8.14.3/8.14.3/Submit) id mBKG7aNe004021; Sat, 20 Dec 2008 17:07:36 +0100 (CET) (envelope-from uqs) Message-Id: <200812201607.mBKG7aNe004021@roadrunner.spoerlein.net> Date: Sat, 20 Dec 2008 17:07:36 +0100 (CET) From: Ulrich Spoerlein To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 X-Mailman-Approved-At: Sat, 20 Dec 2008 16:41:15 +0000 Cc: lioux@FreeBSD.org Subject: ports/129790: [PATCH] net-p2p/mldonkey: Fix rc start script X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Dec 2008 16:20:02 -0000 >Number: 129790 >Category: ports >Synopsis: [PATCH] net-p2p/mldonkey: Fix rc start script >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Dec 20 16:20:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Ulrich Spoerlein >Release: FreeBSD 7.1-PRERELEASE i386 >Organization: >Environment: System: FreeBSD roadrunner.spoerlein.net 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #0: Sat Nov 8 20:43:48 CET >Description: Hi, the start script of mlnet has two issues, since it is overwriting the standard start_cmd routine. It doesn't print the "Starting mlnet." line and does not check for an already running mlnet. Fix this by copying the commands from rc.subr into this script. Port maintainer (lioux@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.77 >How-To-Repeat: >Fix: --- mldonkey-2.9.6_1.patch begins here --- Index: Makefile =================================================================== RCS file: /tank/ncvs/ports/net-p2p/mldonkey/Makefile,v retrieving revision 1.60 diff -u -p -u -r1.60 Makefile --- Makefile 20 Aug 2008 00:57:10 -0000 1.60 +++ Makefile 20 Dec 2008 16:05:57 -0000 @@ -7,6 +7,7 @@ PORTNAME= mldonkey PORTVERSION= 2.9.6 +PORTREVISION= 1 CATEGORIES+= net-p2p MASTER_SITES= ${MASTER_SITE_SOURCEFORGE_EXTENDED} \ ${MASTER_SITE_SAVANNAH} Index: files/mlnet.in =================================================================== RCS file: /tank/ncvs/ports/net-p2p/mldonkey/files/mlnet.in,v retrieving revision 1.3 diff -u -p -u -r1.3 mlnet.in --- files/mlnet.in 26 Jul 2007 02:46:25 -0000 1.3 +++ files/mlnet.in 20 Dec 2008 16:05:57 -0000 @@ -53,6 +53,12 @@ start_cmd() mlnet_logfile="/dev/null" fi + if [ -n "$rc_pid" ]; then + echo 1>&2 "${name} already running? (pid=$rc_pid)." + return 1 + fi + + echo "Starting ${name}." if [ "x${mlnet_user}" = "x$(whoami)" ]; then eval "${command} \ ${mlnet_logcommand} \ --- mldonkey-2.9.6_1.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: