From owner-freebsd-current@FreeBSD.ORG Fri Jul 18 12:40:38 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC84137B401; Fri, 18 Jul 2003 12:40:38 -0700 (PDT) Received: from gw.celabo.org (gw.celabo.org [208.42.49.153]) by mx1.FreeBSD.org (Postfix) with ESMTP id AAB2443F75; Fri, 18 Jul 2003 12:40:36 -0700 (PDT) (envelope-from nectar@celabo.org) Received: from madman.celabo.org (madman.celabo.org [10.0.1.111]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "madman.celabo.org", Issuer "celabo.org CA" (verified OK)) by gw.celabo.org (Postfix) with ESMTP id EF3855482B; Fri, 18 Jul 2003 14:40:29 -0500 (CDT) Received: by madman.celabo.org (Postfix, from userid 1001) id 8596C6D455; Fri, 18 Jul 2003 14:40:29 -0500 (CDT) Date: Fri, 18 Jul 2003 14:40:29 -0500 From: "Jacques A. Vidrine" To: Nate Lawson Message-ID: <20030718194029.GC70721@madman.celabo.org> References: <20030718121511.I26395@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030718121511.I26395@root.org> X-Url: http://www.celabo.org/ User-Agent: Mutt/1.5.4i-ja.1 cc: kan@freebsd.org cc: current@freebsd.org Subject: Re: warning: inlining failed X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jul 2003 19:40:39 -0000 On Fri, Jul 18, 2003 at 12:18:14PM -0700, Nate Lawson wrote: > Warner mentioned this was due to the gcc import. Nearly every part of the > kernel that uses newbus or buf.h prints out lots of warnings. Can someone > see about fixing this, whether it's by fixing our headers or build flags > or gcc itself? I've already wasted a few reboot cycles because valid > warnings were lost in the crowd. > > cc -O -pipe -mcpu=pentiumpro -D_KERNEL -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -DKLD_MODULE -nostdinc -I- -I. -I@ -I@/dev -I@/../include -I/usr/include -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -c > /home/src/sys/modules/ext2fs/../../gnu/ext2fs/ext2_vfsops.c > /home/src/sys/gnu/ext2fs/ext2_vfsops.c: In function `compute_sb_data': > @/sys/buf.h:281: warning: inlining failed in call to `BUF_LOCK' > /home/src/sys/gnu/ext2fs/ext2_vfsops.c:496: warning: called from here > /home/src/sys/gnu/ext2fs/ext2_vfsops.c: In function `ext2_unmount': > @/sys/buf.h:281: warning: inlining failed in call to `BUF_LOCK' > /home/src/sys/gnu/ext2fs/ext2_vfsops.c:774: warning: called from here > @/sys/buf.h:281: warning: inlining failed in call to `BUF_LOCK' > /home/src/sys/gnu/ext2fs/ext2_vfsops.c:780: warning: called from here > @/sys/buf.h:281: warning: inlining failed in call to `BUF_LOCK' > /home/src/sys/gnu/ext2fs/ext2_vfsops.c:784: warning: called from here Does `-finline-limit=1200' (or bigger) help? I think GCC 3.3 added a warning for when inline functions generated `a lot' of instructions. In such a case, the function is not inlined. I believe this also happened with GCC 3.2, but it just didn't normally tell you about it. Cheers, -- Jacques Vidrine . NTT/Verio SME . FreeBSD UNIX . Heimdal nectar@celabo.org . jvidrine@verio.net . nectar@freebsd.org . nectar@kth.se