From owner-svn-src-stable-10@freebsd.org Mon Jul 23 20:36:13 2018 Return-Path: Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3BAE1054334; Mon, 23 Jul 2018 20:36:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 581E58D276; Mon, 23 Jul 2018 20:36:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 9DC8F10A87D; Mon, 23 Jul 2018 16:36:11 -0400 (EDT) Subject: Re: svn commit: r336448 - stable/10 To: rgrimes@freebsd.org References: <201807231736.w6NHadhr032631@pdx.rh.CN85.dnsmgr.net> Cc: Peter Jeremy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org From: John Baldwin Message-ID: <7d86153b-8442-27a3-f152-475116c6b1f5@FreeBSD.org> Date: Mon, 23 Jul 2018 11:02:13 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201807231736.w6NHadhr032631@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 23 Jul 2018 16:36:12 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 20:36:13 -0000 On 7/23/18 10:36 AM, Rodney W. Grimes wrote: >> On 7/18/18 12:05 PM, Peter Jeremy wrote: >>> On 2018-Jul-18 07:41:23 -0700, "Rodney W. Grimes" wrote: >>>>> Author: peterj >>>>> Date: Wed Jul 18 09:32:43 2018 >>>>> New Revision: 336448 >>>>> URL: https://svnweb.freebsd.org/changeset/base/336448 >>>>> >>>>> Log: >>>>> Retrospectively document SVN branch point for stable-10 and its releases. >>>>> >>>>> This is a direct commit to stable/10 because the releases are taken >>>>> from the stable/10 branch. >>>>> >>>>> Approved by: jhb (mentor) >>>>> Differential Revision: D16263 >>>> >>>> Actually I see no reason not to document these in the mainline >>>> UPDATING file and making these MFC's. As is now when looking >>>> at UPDATING from head I can not easily find the branch point >>>> for any of these releases and that is probably the most useful >>>> time for this information. If I already have a branch I probably >>>> already know what its anchor point is. >>> >>> I only put the releng/x.y branch points into the relevant stable/x/UPDATING >>> because releng/x.y is branched off stable/x and I don't think it makes much >>> sense to document those in head/UPDATING. The stable/x branchpoints are in >>> both head/UPDATING and stable/x/UPDATING. Note that the stable/10 branch- >>> point was already in head/UPDATING. >> >> I agree with this. We should document them in the source branch, but not >> in grandparents like head where there is no single head commit that becomes >> releng/X.Y. > > My only counter to this is that often what I am investigating is > the change between ^head/ and some release, say 11.2 and I really > do not want to go grovel in stable/11 to find the rXXXXXX for 11.2, > that is just a PITA. Though the branch point for stable/11 is interesting, > it is rarely usefull for any thing very meaningful. I don't ever grovel around for this in either stable/11 or head to be honest. I usually use the svnweb interface, but doing the svn log quoted previously against a little changed-file on the branch in question (such as MAINTAINERS) via the url is really the better answer. -- John Baldwin