From owner-svn-src-all@FreeBSD.ORG Fri Feb 7 21:53:15 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 55D1540C for ; Fri, 7 Feb 2014 21:53:15 +0000 (UTC) Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com [209.85.215.175]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D79B61D00 for ; Fri, 7 Feb 2014 21:53:14 +0000 (UTC) Received: by mail-ea0-f175.google.com with SMTP id z10so1822968ead.20 for ; Fri, 07 Feb 2014 13:53:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type:subject:from:date:to:cc :message-id; bh=V+21M2kYZtx4CvKOewsFCRT4LBdZvwDmHiHSpxmOBsM=; b=LYWzjYeMc8X4Y017jSFiKloUQvO+FldPNhxWmuMqpRfysap05H9/S7sVNuieZlSXui 6E7TdeMH6GEYRU85JIi5wmv2F2vp8M2kwxIi6XejCe5tWMpMsLYF6QgWw1fkIsGLXDOv 5IIsBBujTI3USW/dOpJ/vVniyfRBmgAqafJLggS6TffUkepbvWAn7/CF5ZOMrIG/f9PD 6BxsvFzoSQFsMr3cO/HY9jf3/xiKZAivlPA7hW2CMGh13KGjWVDNBsFmQp7PkooBe/uG PXDxi4LnwhOMPGv1Nt8elHU2qelvUOfckgWuMTlEqLF31cuV9zVD+FKt+zDuKW/uXlC9 9TxQ== X-Gm-Message-State: ALoCoQloYh5yfgsHlRhfDh1G+n643Sm+fIyxtFiujPFrwWBmb2AXD+sn5rBo8M9NfH31iCal/RlS X-Received: by 10.15.26.8 with SMTP id m8mr19372879eeu.25.1391809515119; Fri, 07 Feb 2014 13:45:15 -0800 (PST) Received: from [192.168.1.81] (87-94-133-95.pool.ukrtel.net. [95.133.94.87]) by mx.google.com with ESMTPSA id k6sm21213010eep.17.2014.02.07.13.45.12 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 07 Feb 2014 13:45:13 -0800 (PST) User-Agent: K-9 Mail for Android In-Reply-To: References: <201402071239.s17CdwIH007683@svn.freebsd.org> <20140207171025.d33b95770f6b0d7d00b4aab3@freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: svn commit: r261585 - head/sys/dev/vt/hw/vga From: Aleksandr Rybalko Date: Fri, 07 Feb 2014 23:44:54 +0200 To: Ed Schouten ,Aleksandr Rybalko Message-ID: Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Feb 2014 21:53:15 -0000 On 7 лютого 2014 р. 23:27:58 GMT+02:00, Ed Schouten wrote: >Hi Aleksandr, > >On 7 February 2014 16:10, Aleksandr Rybalko wrote: >> On Fri, 7 Feb 2014 15:04:47 +0100 >> Ed Schouten wrote: >>> On 7 February 2014 13:39, Aleksandr Rybalko wrote: >> Also people asking me about advanced features of vt(9), like use >> multiple displays. I'm not sure, but signed coordinates may help with >> some things on that way (or makes more problems :) ). > >But if you were to have multiple displays, you should have separate >coordinate systems per display. It should not be seen as a single >pane. I don't really know yet how that will be implemented. :-) > >>> Furthermore, I think it's a bit weird that vga_bitbltchr() contains >>> explicit bounds checking. What happened there? I remember at one >point >>> in time, we had the nice invariant that vt(9) never attempted to >draw >>> outside of the display resolution. What caused us to give up on >that? >> >> Mouse cursor allowed to partially go out of screen, so we have to >check >> (or use special function for mouse cursor). > >Well, that's a compelling argument. Still, it's a bit weird then that >the bitblt function itself does not take signed coordinates. Would it >make sense to bring that in sync then? Yup, this is good idea to sync them. Will do that a bit later. Thanks a lot Ed! Let me know if you will have something more. WBW ------ Aleksandr Rybalko