From owner-freebsd-ports Sun Feb 2 13:50:43 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA17123 for ports-outgoing; Sun, 2 Feb 1997 13:50:43 -0800 (PST) Received: from relay.nuxi.com (nuxi.ucdavis.edu [128.120.37.176]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id NAA17118; Sun, 2 Feb 1997 13:50:41 -0800 (PST) Received: from dragon.nuxi.com (reqd-042.ucdavis.edu [128.120.251.162]) by relay.nuxi.com (8.8.4/8.6.12) with ESMTP id NAA06290; Sun, 2 Feb 1997 13:50:47 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.8.4/8.7.3) id NAA20378; Sun, 2 Feb 1997 13:50:50 -0800 (PST) Message-ID: <19970202135048.PN07710@dragon.nuxi.com> Date: Sun, 2 Feb 1997 13:50:48 -0800 From: obrien@NUXI.com (David O'Brien) To: freebsd-ports@freebsd.org (FreeBSD ports list) Cc: hackers@freebsd.org Subject: conditionally including References: <199701280143.RAA06503@freefall.freebsd.org> X-Mailer: Mutt 0.59-PL19 Mime-Version: 1.0 Organization: The NUXI *BSD group X-PGP-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Keyid: 34F9F9D5 In-Reply-To: ; from Chuck Robey on Jan 27, 1997 21:08:40 -0500 Sender: owner-ports@freebsd.org X-Loop: FreeBSD.org Precedence: bulk Sorry to have to bring this back to light... I was under the impression that we had agreed that "#if (defined(__unix__) || defined(unix))" was the best way to conditionally include . However, this email from Chuck, implies that this is a Bad Thing. So to re-hash this, what does the list think is the best way to have an easy way to include ? Even thought I don't have all the *BSD folks in my grips like I did at USENIX, I'm still not above trying to get a new cpp symbol added (like __44bsd__ or something). Chuck Robey writes: > > obrien 97/01/27 17:43:23 > > Modified: share/doc/handbook porting.sgml > > Document the "#if (defined(__unix__) || defined(unix))" way of including > > sys/param.h. Change _HAVE_PARAM_H to "HAVE_SYS_PARAM_H" for those who > > still like this method -- leading underscores are in the compiler/library > > name space and the Ollivier says to follow GNU Autoconf anyway. > > That test is completely bogus, cause it passes for all sysv systems, > which _don't_ have sys/param.h. It's a completely useless test, and > someone justified it by saying that "most systems have a sys/param.h > anyhow". > > What (in my own opinion) should have been done is to detect: > > #ifdef FreeBSD || NetBSD || OpenBSD > > that would have worked for those variants. Would be able to find out the > one for BSDi systems, then we'd have a great deal of the important ones. > That's how X11R6 does it. -- -- David (obrien@NUXI.com -or- obrien@FreeBSD.org)