From owner-svn-src-head@FreeBSD.ORG Mon Jun 21 19:05:51 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 38BDF106564A; Mon, 21 Jun 2010 19:05:51 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 9BA398FC18; Mon, 21 Jun 2010 19:05:50 +0000 (UTC) Received: by gyh20 with SMTP id 20so3273573gyh.13 for ; Mon, 21 Jun 2010 12:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=fK9cHjdVVM2loRiPyZjqwAZ79H75UNAC4zVgpSoHNgQ=; b=EjTtE35Vd+Mg21mclhMoyZtA9bqeed1eBWDHOQVYnApgOWD5+ym7bZvNhm8mozFSWw GPK5EfYwLiU6LrH8kfnGUmWDSrH0p2xLSD0yt0vj93Wde3PBv8RSOkQ9WViC8M0zTb0o TX3yJ0I44x4cRZBGMIqKMQ7mic9dr5PrIAYuU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=PHCdRHeDgKNlZKyZd6508qd3MfDd1ARlNyguhjq/Ss6mBcldjiYDD0S2OZGd83FAnx 98XyTB3g0vdhMZnocm9dAKcCVeJLlw/08D09Z3szMk40aqdFTM0cmh835NMtp5XGD3as 36cPQ48nRqpBMSnWp8jZxkm8pkJ9T2B9S4Kwc= Received: by 10.229.186.135 with SMTP id cs7mr2744029qcb.4.1277147149705; Mon, 21 Jun 2010 12:05:49 -0700 (PDT) Received: from kan.dnsalias.net (c-24-63-226-98.hsd1.ma.comcast.net [24.63.226.98]) by mx.google.com with ESMTPS id x34sm51262674qce.39.2010.06.21.12.05.48 (version=SSLv3 cipher=RC4-MD5); Mon, 21 Jun 2010 12:05:48 -0700 (PDT) Date: Mon, 21 Jun 2010 15:05:44 -0400 From: Alexander Kabaev To: Bruce Evans Message-ID: <20100621150544.094de36a@kan.dnsalias.net> In-Reply-To: <20100622041935.J44301@delplex.bde.org> References: <201006200034.o5K0Y6xl041024@svn.freebsd.org> <20100622024652.C43995@delplex.bde.org> <20100621133340.7501713b@kan.dnsalias.net> <20100622041935.J44301@delplex.bde.org> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/DjS3c48Jj_20RNX43UHywwG"; protocol="application/pgp-signature" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar , src-committers@freebsd.org Subject: Re: svn commit: r209358 - head/cddl/contrib/opensolaris/lib/libdtrace/common X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2010 19:05:51 -0000 --Sig_/DjS3c48Jj_20RNX43UHywwG Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 22 Jun 2010 04:30:12 +1000 (EST) Bruce Evans wrote: > On Mon, 21 Jun 2010, Alexander Kabaev wrote: >=20 > > On Tue, 22 Jun 2010 03:22:40 +1000 (EST) > > Bruce Evans wrote: > > > > > > DTrace _does_ try to unput EOF though and apparently gets away with > > it on Solaris, so while yor version is correct, it is also useless. >=20 > Do you mean that it tries to unput EOF as an int (not obtained from a > char), and that that must fail and not unput ((unsigned char)EOF)? > Then the current version is still broken on platforms with chars > signed, since when it tries to unput a char with value EOF, that will > fail and not unput ((unsigned char)). Correct, but chances of valid DTrace script having 0xff character in them is pretty much nonexistent, so I let that slide rather than pushing more changes into externally maintained code. To be absolutely correct, I think, we need to declare unput() as inline/static taking int argument and make sure that we invoke it as unput((unsigned char)*q) every time q is declared as char *. --=20 Alexander Kabaev --Sig_/DjS3c48Jj_20RNX43UHywwG Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iD8DBQFMH7gLQ6z1jMm+XZYRAnInAJ428KTLRLk/JrBSu8yseo+VTYTKXACcC3a5 J2Xif5/rD3vIGKd6FLcVpYk= =uVbI -----END PGP SIGNATURE----- --Sig_/DjS3c48Jj_20RNX43UHywwG--