From owner-freebsd-gnome@FreeBSD.ORG Sat Sep 16 22:40:24 2006 Return-Path: X-Original-To: gnome@hub.freebsd.org Delivered-To: freebsd-gnome@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E2BDD16A403 for ; Sat, 16 Sep 2006 22:40:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5718243D49 for ; Sat, 16 Sep 2006 22:40:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k8GMeOXg040473 for ; Sat, 16 Sep 2006 22:40:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k8GMeOAT040472; Sat, 16 Sep 2006 22:40:24 GMT (envelope-from gnats) Date: Sat, 16 Sep 2006 22:40:24 GMT Message-Id: <200609162240.k8GMeOAT040472@freefall.freebsd.org> To: gnome@FreeBSD.org From: chinsan Cc: Subject: Re: ports/103268: [PATCH] print/freetype2: Fix TTF_BYTECODE_ENABLED X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: chinsan List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Sep 2006 22:40:25 -0000 The following reply was made to PR ports/103268; it has been noted by GNATS. From: chinsan To: "Joe Marcus Clarke" Cc: bug-followup@freebsd.org Subject: Re: ports/103268: [PATCH] print/freetype2: Fix TTF_BYTECODE_ENABLED Date: Sun, 17 Sep 2006 06:30:27 +0800 2006/9/17, Joe Marcus Clarke : > What exactly is wrong with it? Your description doesn't include any > details. Hi, marcus: Sorry, I forget to write the detail of this bug. :p the default freetype2 port seems like enable TTF_BYTECODE function by default. .if !defined(WITHOUT_TTF_BYTECODE_ENABLED) CFLAGS+= -DTT_CONFIG_OPTION_BYTECODE_INTERPRETER .endif In fact, it is not enabled by default: /* #define TT_CONFIG_OPTION_BYTECODE_INTERPRETER */ Therefore, this(freetype/config/ftoption.h) does not work with -DTT_CONFIG_OPTION_BYTECODE_INTERPRETER. However, when TT_CONFIG_OPTION_UNPATENTED_HINTING is defined, freetype2 will still use auto-hinter by default, except the applications use especially way to use BYTECODE_INTERPRETER. So, I made a patch with the following result: diff -ruN work/freetype-2.1.10/include/freetype/config/ftoption.h.bak work/freetype-2.1.10/include/freetype/config/ftoption.h --- work/freetype-2.1.10/include/freetype/config/ftoption.h.bak Mon Jun 6 23:37:53 2005 +++ work/freetype-2.1.10/include/freetype/config/ftoption.h Fri Sep 15 22:48:04 2006 @@ -436,7 +436,7 @@ /* Do not #undef this macro here, since the build system might */ /* define it for certain configurations only. */ /* */ -/* #define TT_CONFIG_OPTION_BYTECODE_INTERPRETER */ +#define TT_CONFIG_OPTION_BYTECODE_INTERPRETER /*************************************************************************/ @@ -448,7 +448,7 @@ /* FT_PARAM_TAG_UNPATENTED_HINTING; or when the debug hook */ /* FT_DEBUG_HOOK_UNPATENTED_HINTING is globally activated. */ /* */ -#define TT_CONFIG_OPTION_UNPATENTED_HINTING +/* #define TT_CONFIG_OPTION_UNPATENTED_HINTING */ /*************************************************************************/