From owner-svn-src-all@freebsd.org Sat Nov 14 00:53:11 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6FFE7463AB5 for ; Sat, 14 Nov 2020 00:53:11 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CXxdz2csFz3PWb for ; Sat, 14 Nov 2020 00:53:11 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f52.google.com with SMTP id j7so12167931wrp.3 for ; Fri, 13 Nov 2020 16:53:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ID4pCHw2fLBil52z+aTxuC4S5OF2rizsh1BQVx8ZHvs=; b=nQIAlkjmKs5YC8fbMjqwaV2raecGTiKfjY0VbniXF1tP0SGMCFcuXIBYqUflCBuauh Y8FGezzKpF5e/bwSYwCuBHwOTgDYmComGmZocGR94PwACSeqWW+RmA6U/SfT7PvTrJqo pbDMubcH0NK+busaGDEiDjl52Z9ykuPt6bcnWmAQ57SrlCMllwO5ktX52U3+1jxsWSc4 HfxjLfXtLcW6XrZu5bVR3JdnfXH5v5DXBmNSbrIOMluBpzKOx8spUVQ+RIruQuKZSo+d EhGrVTu0qNomwu6Q/fyxxJQSfF/KudDsd5RiOFm5H98JRl9ETgF22VorlRKf4iPvM0T4 cb8Q== X-Gm-Message-State: AOAM531HzptJrPOFaFv3wbJpNt9OkIuqcR0PZi4i0Ge1EwCHlYf4KhRn fpkHYp/sQIjrtLWYE8eu5u9/Ww== X-Google-Smtp-Source: ABdhPJw1xUwDKNz9KH1yJhHnXcrNfhPErWoQadNYQlFSJDT5nJXHz6NRqyaFAxUBMpKei3owBPZvTw== X-Received: by 2002:adf:f0c2:: with SMTP id x2mr6579305wro.184.1605315189900; Fri, 13 Nov 2020 16:53:09 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id m20sm15835762wrg.81.2020.11.13.16.53.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Nov 2020 16:53:09 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: svn commit: r367651 - head/usr.sbin/bhyve From: Jessica Clarke In-Reply-To: <328D3129-4682-491B-A28F-D6739E52ABE8@panasas.com> Date: Sat, 14 Nov 2020 00:53:07 +0000 Cc: Rebecca Cran , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <202011131947.0ADJlGbr064616@repo.freebsd.org> <328D3129-4682-491B-A28F-D6739E52ABE8@panasas.com> To: Ravi Pokala X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4CXxdz2csFz3PWb X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2020 00:53:11 -0000 On 14 Nov 2020, at 00:47, Ravi Pokala wrote: >=20 >> +#define FIRMWARE_RELEASE_DATE "11/10/2020" >=20 > Might I suggest "2020-11-10", as sorting, logic, ${DEITY}, and = ISO-8601 demand? ;-) Alas that is a "feature" of the specification: String number of the BIOS release date. The date string, if supplied, is in either mm/dd/yy or mm/dd/yyyy format. If the year portion of the string is two digits, the year is assumed to be 19yy. NOTE: The mm/dd/yyyy format is required for SMBIOS version 2.3 and later. (SMBIOS Specification version 3.4.0c) It might be worth putting a comment in so people don't accidentally change it to the wrong thing in future though, given it's currently ambiguous otherwise. Jess