From owner-freebsd-bugs@FreeBSD.ORG  Wed Mar  7 16:00:32 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DBF351065676
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  7 Mar 2012 16:00:32 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 6E88A8FC4A
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  7 Mar 2012 16:00:27 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q27G0RIO023637
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 7 Mar 2012 16:00:27 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q27G0RET023631;
	Wed, 7 Mar 2012 16:00:27 GMT (envelope-from gnats)
Resent-Date: Wed, 7 Mar 2012 16:00:27 GMT
Resent-Message-Id: <201203071600.q27G0RET023631@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Andreas Longwitz <longwitz@incore.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EAEB51065672
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed,  7 Mar 2012 15:55:56 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id DA25C8FC19
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed,  7 Mar 2012 15:55:56 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q27FtuiG074200
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 7 Mar 2012 15:55:56 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q27FtuTE074199;
	Wed, 7 Mar 2012 15:55:56 GMT (envelope-from nobody)
Message-Id: <201203071555.q27FtuTE074199@red.freebsd.org>
Date: Wed, 7 Mar 2012 15:55:56 GMT
From: Andreas Longwitz <longwitz@incore.de>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: bin/165821: missing "-J" in "dumpfs -m" for gjournal file systems
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Mar 2012 16:00:32 -0000


>Number:         165821
>Category:       bin
>Synopsis:       missing "-J" in "dumpfs -m" for gjournal file systems
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 07 16:00:27 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Andreas Longwitz
>Release:        FreeBSD 8.2-STABLE
>Organization:
Data Service Stockelsdorf
>Environment:
FreeBSD dsssrvt2.incore 8.2-STABLE FreeBSD 8.2-STABLE #0: Wed Feb 22 14:47:19 CET 2012 root@dsssrvt2.incore:/usr/obj/usr/src/sys/SERVER64  amd64
>Description:
The command dumpfs -m fs for a gjournal file system fs does not put "-J" to his output.
>How-To-Repeat:

>Fix:
--- sbin/dumpfs/dumpfs.c.orig   2012-01-26 12:41:54.000000000 +0100
+++ sbin/dumpfs/dumpfs.c        2012-03-07 16:41:48.000000000 +0100
@@ -408,6 +408,8 @@
        printf("-O %d ", disk.d_ufs);
        if (fs->fs_flags & FS_DOSOFTDEP)
                printf("-U ");
+       if (fs->fs_flags & FS_GJOURNAL)
+               printf("-J ");
        printf("-a %d ", fs->fs_maxcontig);
        printf("-b %d ", fs->fs_bsize);
        /* -c is dumb */

>Release-Note:
>Audit-Trail:
>Unformatted: