From owner-cvs-all  Sat Jun 15 21:39:10 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 44D6E37B416; Sat, 15 Jun 2002 21:39:05 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id OAA29449;
	Sun, 16 Jun 2002 14:39:02 +1000
Date: Sun, 16 Jun 2002 14:43:39 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: "Greg 'groggy' Lehey" <grog@FreeBSD.org>
Cc: Pete Fritchman <petef@absolutbsd.org>,
	Alexey Zelkin <phantom@ark.cris.net>, <cvs-committers@FreeBSD.org>,
	<cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/usr.bin/calendar Makefile
In-Reply-To: <20020616000418.GE65995@wantadilla.lemis.com>
Message-ID: <20020616142952.H2113-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sun, 16 Jun 2002, Greg 'groggy' Lehey wrote:

> Ah, thanks.  So what about this?
>
> .for lang in ${INTER}
> 	install -d -o ${BINOWN} -g ${BINGRP} -m ${DIRMODE} ${DESTDIR}${SHAREDIR}/calendar/${lang}
> 	${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m ${TEXTMODE} \
> 		${.CURDIR}/calendars/${lang}/calendar.* \
> 		${DESTDIR}${SHAREDIR}/calendar/${lang}
> .endfor

Style bugs at best :-).  Apart from just using install -d, it hard-codes
${INSTALL} and has a line longer than 80 characters mixed with carefully
split lines in old code.

> I know that this doesn't address the question about whether this
> should be done by mtree or not.  Normally it would, but I don't
> believe that the 'make install' should fail because it's done in the
> directory.

It's less that useful with out this addressing.  The addressing might
involve propagating the attributes set in this file to the mtree
database or vice versa.  This would be too complicated for me.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message