From owner-svn-src-all@FreeBSD.ORG Wed Oct 22 14:02:55 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 468E4BA8 for ; Wed, 22 Oct 2014 14:02:55 +0000 (UTC) Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 12FDFCF8 for ; Wed, 22 Oct 2014 14:02:54 +0000 (UTC) Received: by mail-pa0-f45.google.com with SMTP id lj1so3752480pab.4 for ; Wed, 22 Oct 2014 07:02:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=sat6zkkGpXLQy7xiyndxI8Ds3eZ3JbviEt+jaT+Egl8=; b=XvHG1jlicIL+/FBukE26yxJFcGWfokLg/Dx+V9lXRWP9JYawZ8+gAPGobBEJKevHuc zgY2eRgdn9Q1CU0lvByX5mxuZMNYz9HFlldPOiGjQ3woO63ftLsikzbUix5Gaxy6oSjb AuOYPC0PeBteJVeAYKj3epLSUxxX02p9ETYjDBQlasQYFfdlz+YNN9u7wfvAiNOzI/n6 /xdwDlTVDvKT1/zyWmMDOYbPyKQ6X11zVdkbUwxm16P/XMPj9Nrm2BEIS14sCY86pTVK 2smjBA7KeVvioaTSItIKanUhOYIX8pt86Cxc62nb/BfbQ/TG7TXkVN2U08abRqt5m2vu Qmag== X-Gm-Message-State: ALoCoQnWSYTOfVFGB5pbsw+Zc3Y9P965Kgvb/dqmD1PqKzJfH1+6cx4eeUwL1ErdnSK5ZR80iHBM X-Received: by 10.70.109.139 with SMTP id hs11mr23218016pdb.83.1413986573849; Wed, 22 Oct 2014 07:02:53 -0700 (PDT) Received: from macintosh-c42c033c0b73.corp.netflix.com (dc1-prod.netflix.com. [69.53.236.251]) by mx.google.com with ESMTPSA id ps7sm14315509pbb.73.2014.10.22.07.02.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 Oct 2014 07:02:53 -0700 (PDT) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_4C5EC1F4-95DC-4993-BAC2-200E4D0B9CA3"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r273417 - head From: Warner Losh In-Reply-To: <86iojco2oh.fsf@nine.des.no> Date: Wed, 22 Oct 2014 08:02:49 -0600 Message-Id: <6287010D-9C54-4167-9784-84134080A419@bsdimp.com> References: <201410212029.s9LKThT2074337@svn.freebsd.org> <86d29k28wh.fsf@nine.des.no> <22788EC4-3BDF-40F3-ACAC-FA686ED21154@bsdimp.com> <86iojco2oh.fsf@nine.des.no> To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 14:02:55 -0000 --Apple-Mail=_4C5EC1F4-95DC-4993-BAC2-200E4D0B9CA3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Oct 22, 2014, at 3:48 AM, Dag-Erling Sm=F8rgrav wrote: > Warner Losh writes: >> I=92ll fix this. I think we need to have a MK_TESTS_SUPPORT that = builds >> the libatf stuff when yes, and omits it when no, since we don=92t = want >> the tests building when we=92re building the 4.3 stage. >=20 > I agree, bundling everything under MK_TESTS does not make much sense. > Automake has the same bug ("make check" will both build the tests and > run them, and while you can rerun the tests without rebuilding them > ("make recheck"), there is no way to build them without running them. >=20 > I would prefer calling this MK_ATF than MK_TESTS_SUPPORT, though. The > test framework is probably useful on its own. That would be a nicer name, but then we=92d lose the automatic setting = when MK_TESTS is enabled (unless we add another special case, which is the opposite = direction that I want to go in). How strongly do you feel that=92s a better name? Warner --Apple-Mail=_4C5EC1F4-95DC-4993-BAC2-200E4D0B9CA3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUR7kKAAoJEGwc0Sh9sBEAK9MP/A/zrxF7PUIfpQq98M9UM2ky K/0Vjjc/mOPBNCBirkE2HG+J+QRmjZ5O23+J9E+AWCCz7+ucPVT3T0vanx8pHm4W x3bTAJvE76W8KKpPQyCQEgN7ZiK/PdNIB9mqWwOqExLzZ7MCUdIDQK7Bi01WnPbs aMYFEMP9md/cu7HX90TkAhzjn0awK6zOYeHx1fGonTce0WhQvSsPHeUX0IobVwbP 85TuLXOiEKezC1wJn1MhzW6XfplVY2kPNgfQ6oAw0U0pqBghUQpymbFemezScqOG ELPMUlNLvchyrL8T0rlIpYeuOX9zlCLBsu3jWMkwSNqVBFktl+eD/SwWOOu1Bj8X xBcH50sD7Me4bITsaUZ9nHcdKpXdThqlGwzfop/b1fuYgBUsXiNUebBtYuL8gQKP HVL4wCTBy2levCqd0rm0G4WLXq2hsmCEpBASPhkR4K6L1m5mKw2DWAXnWieOnX8S snXuJ5h3cULEST8fZqbdh6/u23/ka+mFRh4FRIk+5sjjMHQ2IMpdyJC8Yz/D1GEI 795T4bpFm6MIyD0JeZ6eNYS1PMq2Zp/qXoUYGgcA97kiseQLYoUqiOpUKd24AVqX R1PbhO/QTrkf8J5O763DIH6ABTrdO0Uhhbl8FqZBLW1YA6vHkV3jNTfiJscvM7uV M6yA9ztaAJXOp1suyvia =smAw -----END PGP SIGNATURE----- --Apple-Mail=_4C5EC1F4-95DC-4993-BAC2-200E4D0B9CA3--