From nobody Sat Mar 8 08:13:49 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z8wsT3cszz5qcnL; Sat, 08 Mar 2025 08:13:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z8wsT32SPz3klC; Sat, 08 Mar 2025 08:13:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741421629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=36N68G69tM8qrwBC2flmZXY2CnI7faulXbpmntrAnsg=; b=lxdlcuso3eBqxupKSFuEXaB2d7DZfY9DLrFkSXeeOyIJ7QVXPmZMTkEy/cCFs/YM9dGfiI lOndgeKdEu2gofkAkHagLYk+QSik9FJDuM/t8A+mLxZqe30zjigW/kJEw+oZHwliON3RoS OYPiBZfRT6YqtjwRF0wxvrIhtULFnK47HzxmEaN85/L2q0lQLixvEzUghyxojySRY5MR+d eDq/TxR0kZz2umn/4X10T/PjOOpFCqdZgahfrZ03+QzXf+YS589FKxljmGi+PMafkXyCU3 lWouFfvZUWivq52oHYKMMOiElY4CrTGp+ZTiqIBj6CClmrMQspV+gpcrnjXSTQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741421629; a=rsa-sha256; cv=none; b=fqIyRU3G2mNrh6gRLVmerphHHbku9PMYmsY7wFwD4GqzrPONKW2p7ylaKChPiUjY1DiKDx wUIvZ1Bw3KKccm97S3uNMKQooFrbTtTUdotqDJNFdzzc0Gj2dktTNF4wprSXp+uLPIif6s F2isHPnj0GGB1m8OMYNIL3Ra9x7WMY6QPG0fgZm6YL10rBNOHpoY9tExDciOkDQVktb9N1 D6Jd7Txm7EJ+0hWE68oHQPrEfN3tBzLtRXpFqI24GjcZyvInwbOTTU2jLFtwWrT8IzWWfT /yUYu3L+llyNbLSP4TNFlxbm289zOS9Z+7lUdSiNYDPg9fmen42jo3lZSbwzog== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741421629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=36N68G69tM8qrwBC2flmZXY2CnI7faulXbpmntrAnsg=; b=DKH+VrfE65i2jqVEWTIh+ngMf+7Xz5HQwib7jpfR4Z7yeHLFFMpyzRugIhhB4XxU5NFwne ErlZofBHPDHMab7si34Usc85l0c/o+U6kIfmwmzfX2MjuafDnE5xriXMgbQFs1pfS/Zr8s j1PKSulMHp2AYXaZfDJFX1f0VF6kznD+ejSiO7oDR/BwWCdcDJ8vMNmBjMdorjdGHseoTC JP8NOUPVCyqQ8eSxNYfxWjbCYfcbsNWTHkvnEBC21tCgxuou3k2YmFXmxmgrBrKeRj0+xl vBj0zimVBaS3mChjGsjphhYGb4iaWz9XCdgXVdl2DHh87JK8+CLFJzH9SaLa/Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z8wsT2bQ5zd9; Sat, 08 Mar 2025 08:13:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5288Dnce097390; Sat, 8 Mar 2025 08:13:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5288DnPJ097387; Sat, 8 Mar 2025 08:13:49 GMT (envelope-from git) Date: Sat, 8 Mar 2025 08:13:49 GMT Message-Id: <202503080813.5288DnPJ097387@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 9d4823824d40 - stable/14 - gve: Disallow MTUs within a problematic range List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 9d4823824d4073313f758dd67ba9212bfcb39306 Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=9d4823824d4073313f758dd67ba9212bfcb39306 commit 9d4823824d4073313f758dd67ba9212bfcb39306 Author: Jasper Tran O'Leary AuthorDate: 2025-02-14 14:57:06 +0000 Commit: Mark Johnston CommitDate: 2025-03-07 22:51:48 +0000 gve: Disallow MTUs within a problematic range If hardware LRO is enabled with GVE, then setting the driver's MTU to a range of values around 8000 will cause dropped packets and drastically degraded performance. While this issue is being investigated, we need to prohibit the driver's MTU being set to a value within this range. Signed-off-by: Jasper Tran O'Leary Reviewed by: delphij, markj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D48971 (cherry picked from commit 909e2d7b691f7418a78b1289a51d3b6c46860a9b) --- sys/dev/gve/gve_main.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sys/dev/gve/gve_main.c b/sys/dev/gve/gve_main.c index 0e40656ca928..c726177c199c 100644 --- a/sys/dev/gve/gve_main.c +++ b/sys/dev/gve/gve_main.c @@ -196,6 +196,8 @@ static int gve_set_mtu(if_t ifp, uint32_t new_mtu) { struct gve_priv *priv = if_getsoftc(ifp); + const uint32_t max_problem_range = 8227; + const uint32_t min_problem_range = 7822; int err; if ((new_mtu > priv->max_mtu) || (new_mtu < ETHERMIN)) { @@ -204,6 +206,19 @@ gve_set_mtu(if_t ifp, uint32_t new_mtu) return (EINVAL); } + /* + * When hardware LRO is enabled in DQ mode, MTUs within the range + * [7822, 8227] trigger hardware issues which cause a drastic drop + * in throughput. + */ + if (!gve_is_gqi(priv) && !gve_disable_hw_lro && + new_mtu >= min_problem_range && new_mtu <= max_problem_range) { + device_printf(priv->dev, + "Cannot set to MTU to %d within the range [%d, %d] while hardware LRO is enabled\n", + new_mtu, min_problem_range, max_problem_range); + return (EINVAL); + } + err = gve_adminq_set_mtu(priv, new_mtu); if (err == 0) { if (bootverbose)