From owner-freebsd-bugs@freebsd.org Tue Sep 12 19:00:34 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4922CE17ECE for ; Tue, 12 Sep 2017 19:00:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2EFD481678 for ; Tue, 12 Sep 2017 19:00:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v8CJ0XIY095212 for ; Tue, 12 Sep 2017 19:00:34 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 222258] renameat(2) capability error with absolute path names outside of a sandbox Date: Tue, 12 Sep 2017 19:00:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 19:00:34 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222258 Conrad Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rwatson@FreeBSD.org --- Comment #1 from Conrad Meyer --- This is a little odd. The kernel implementation of rename(2) just invokes kern_renameat() with AT_FDCWD, like renameat() with AT_FDCWD. But perhaps = Perl in *at() mode uses fds other than AT_FDCWD. Looking at namei() and sys_capability.c, I don't see where we ever check if= a thread is sandboxed or not. It seems like something like this might be nee= ded, although I'm not sure if it is sufficient: --- a/sys/kern/kern_descrip.c +++ b/sys/kern/kern_descrip.c @@ -2492,9 +2492,11 @@ fget_cap_locked(struct filedesc *fdp, int fd, cap_rights_t *needrightsp, } #ifdef CAPABILITIES - error =3D cap_check(cap_rights_fde(fde), needrightsp); - if (error !=3D 0) - goto out; + if (IN_CAPABILITY_MODE(curthread)) { + error =3D cap_check(cap_rights_fde(fde), needrightsp); + if (error !=3D 0) + goto out; + } #endif if (havecapsp !=3D NULL) @@ -2593,9 +2595,11 @@ fget_unlocked(struct filedesc *fdp, int fd, cap_righ= ts_t *needrightsp, if (fp =3D=3D NULL) return (EBADF); #ifdef CAPABILITIES - error =3D cap_check(&haverights, needrightsp); - if (error !=3D 0) - return (error); + if (IN_CAPABILITY_MODE(curthread)) { + error =3D cap_check(&haverights, needrightsp); + if (error !=3D 0) + return (error); + } #endif count =3D fp->f_count; retry: --=20 You are receiving this mail because: You are the assignee for the bug.=