From owner-svn-src-all@freebsd.org Wed Jun 1 16:30:06 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 861FBB619A6; Wed, 1 Jun 2016 16:30:06 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6356119A7; Wed, 1 Jun 2016 16:30:06 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 1AE8BB94C; Wed, 1 Jun 2016 12:30:05 -0400 (EDT) From: John Baldwin To: Julian Elischer Cc: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299393 - in head: . share/mk Date: Wed, 01 Jun 2016 09:28:58 -0700 Message-ID: <1635327.lWf6hTW5HF@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: References: <201605102232.u4AMWNvp000287@repo.freebsd.org> <6335113.N7gIF2Maer@ralph.baldwin.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 01 Jun 2016 12:30:05 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 16:30:06 -0000 On Monday, May 30, 2016 01:21:50 PM Julian Elischer wrote: > On 27/05/2016 2:28 AM, John Baldwin wrote: > > On Wednesday, May 25, 2016 03:27:07 PM Hans Petter Selasky wrote: > >> On 05/11/16 00:32, John Baldwin wrote: > >>> Author: jhb > >>> Date: Tue May 10 22:32:23 2016 > >>> New Revision: 299393 > >>> URL: https://svnweb.freebsd.org/changeset/base/299393 > >>> > >>> Log: > >>> Change the default installation directory for modules to /boot/modules. > >>> > >>> Kernel installs always override KMODDIR when installing modules, so > >>> this default setting is only used for standalone module builds. Many > >>> out-of-tree modules manually override KMODDIR already to avoid placing > >>> modules in /boot/kernel. This now makes that behavior the default. > >>> > >>> Discussed on: arch@ > >>> Reviewed by: imp > >>> Relnotes: yes > >>> > >> Just a small nit: > >> > >> There is a comment in bsd.own.mk which needs updating too: > >> > >>> # > >>> # KMODDIR Base path for loadable kernel modules > >>> # (see kld(4)). [/boot/kernel] > > Oops, thanks. Fixed. > > the comment should also mention it does not cover in-tree modules. Actually, it does. If you cd /sys/modules/foo and run make install it installs to this path. Only buildkernel overrides this explicitly when installing the modules built together with a kernel. -- John Baldwin