From owner-freebsd-arch@FreeBSD.ORG Tue Jun 18 11:27:06 2013 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 0B8089F5; Tue, 18 Jun 2013 11:27:06 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.lysator.liu.se (mail.lysator.liu.se [IPv6:2001:6b0:17:f0a0::3]) by mx1.freebsd.org (Postfix) with ESMTP id B2B2210FB; Tue, 18 Jun 2013 11:27:05 +0000 (UTC) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 2CE0740013; Tue, 18 Jun 2013 13:27:04 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 22FB940005; Tue, 18 Jun 2013 13:27:04 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=AWL autolearn=disabled version=3.3.1 X-Spam-Score: 0.0 Received: from mx.daemonic.se (mx.daemonic.se [IPv6:2001:470:dca9:0:1::3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id EF2B240002; Tue, 18 Jun 2013 13:27:02 +0200 (CEST) Received: from mailscanner.daemonic.se (mailscanner.daemonic.se [IPv6:2001:470:dca9:0:1::6]) by mx.daemonic.se (Postfix) with ESMTPS id 3bZRpF5SkDz8hVn; Tue, 18 Jun 2013 13:27:01 +0200 (CEST) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mx.daemonic.se ([IPv6:2001:470:dca9:0:1::3]) (using TLS with cipher CAMELLIA256-SHA) by mailscanner.daemonic.se (mailscanner.daemonic.se [IPv6:2001:470:dca9:0:1::6]) (amavisd-new, port 10025) with ESMTPS id teyDhAF1zkno; Tue, 18 Jun 2013 13:26:59 +0200 (CEST) Received: from mail.daemonic.se (mail.daemonic.se [10.1.0.4]) by mx.daemonic.se (Postfix) with ESMTPS id 3bZRpC2LMzz8hVm; Tue, 18 Jun 2013 13:26:59 +0200 (CEST) Received: from [IPv6:::1] (celes.daemonic.se [IPv6:2001:470:dca9:1::3]) by mail.daemonic.se (Postfix) with ESMTPSA id 3bZRpB4lt0z9Ctq; Tue, 18 Jun 2013 13:26:58 +0200 (CEST) Message-ID: <51C04404.3080509@freebsd.org> Date: Tue, 18 Jun 2013 13:27:00 +0200 From: Niclas Zeising User-Agent: Mutt/1.5.21 MIME-Version: 1.0 To: Robert Millan Subject: Re: Bus space routines References: <51C0345E.4000309@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 130618-0, 2013-06-18), Outbound message X-Antivirus-Status: Clean X-Virus-Scanned: ClamAV using ClamSMTP Cc: arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jun 2013 11:27:06 -0000 On 2013-06-18 12:56, Robert Millan wrote: > Hi Niclas, > > Thank you for bringing this up. > > 2013/6/18 Niclas Zeising >> In a first incarnation it used the bus_space* routines, see >> this patch: >> >> http://trillian.chruetertee.ch/ports/browser/trunk/devel/libpciaccess/files/patch-src-freebsd_pci.c?rev=591 > > Yes, this was my original patch. I wrote it to fix a problem on > GNU/kFreeBSD. As always, I took care to do things in a way that would > be likely to work on FreeBSD as well (rather than, e.g. using > ). And for that you have my gratitude, it was very nice to be able to take the patch from debian instead of having to try to make something myself. > >> This was later changed to use the in*/out* macros directly, with the >> motivation that the bus_space* functions is a KPI that shouldn't be used >> in userland. See following for an updated patch: >> >> http://trillian.chruetertee.ch/ports/browser/trunk/devel/libpciaccess/files/patch-src-freebsd_pci.c?rev=815 > > Actually, based on previous discussion my understanding was that it's > in*/out* which wasn't ment to be used in userland: > > http://lists.freebsd.org/pipermail/freebsd-arch/2012-March/012470.html I have no idea what's the correct or best way, that's why I brought it up again, to get some sort of consensus. :) Regards! -- Niclas