Date: Tue, 18 Jun 2013 13:27:00 +0200 From: Niclas Zeising <zeising@freebsd.org> To: Robert Millan <rmh@freebsd.org> Cc: arch@freebsd.org Subject: Re: Bus space routines Message-ID: <51C04404.3080509@freebsd.org> In-Reply-To: <CAOfDtXNWMO-D1D9UAcvG_nhv4uqMQmrpEvsPd-PAEB1-FdoXtA@mail.gmail.com> References: <51C0345E.4000309@freebsd.org> <CAOfDtXNWMO-D1D9UAcvG_nhv4uqMQmrpEvsPd-PAEB1-FdoXtA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2013-06-18 12:56, Robert Millan wrote: > Hi Niclas, > > Thank you for bringing this up. > > 2013/6/18 Niclas Zeising <zeising@freebsd.org> >> In a first incarnation it used the bus_space* routines, see >> this patch: >> >> http://trillian.chruetertee.ch/ports/browser/trunk/devel/libpciaccess/files/patch-src-freebsd_pci.c?rev=591 > > Yes, this was my original patch. I wrote it to fix a problem on > GNU/kFreeBSD. As always, I took care to do things in a way that would > be likely to work on FreeBSD as well (rather than, e.g. using > <sys/io.h>). And for that you have my gratitude, it was very nice to be able to take the patch from debian instead of having to try to make something myself. > >> This was later changed to use the in*/out* macros directly, with the >> motivation that the bus_space* functions is a KPI that shouldn't be used >> in userland. See following for an updated patch: >> >> http://trillian.chruetertee.ch/ports/browser/trunk/devel/libpciaccess/files/patch-src-freebsd_pci.c?rev=815 > > Actually, based on previous discussion my understanding was that it's > in*/out* which wasn't ment to be used in userland: > > http://lists.freebsd.org/pipermail/freebsd-arch/2012-March/012470.html I have no idea what's the correct or best way, that's why I brought it up again, to get some sort of consensus. :) Regards! -- Niclas
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51C04404.3080509>