From owner-freebsd-current@FreeBSD.ORG Mon Sep 8 02:34:30 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from hub.FreeBSD.org (hub.freebsd.org [IPv6:2001:1900:2254:206c::16:88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E268EBEB; Mon, 8 Sep 2014 02:34:29 +0000 (UTC) Date: Sun, 7 Sep 2014 22:34:25 -0400 From: Glen Barber To: yaneurabeya@gmail.com Subject: Re: NO INET6 warning Message-ID: <20140908023425.GF48287@hub.FreeBSD.org> References: <1410123815.10027.18.camel@bruno> <20140907210802.GA48287@hub.FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="R6sEYoIZpp9JErk7" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event User-Agent: Mutt/1.5.23 (2014-03-12) Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2014 02:34:30 -0000 --R6sEYoIZpp9JErk7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 07, 2014 at 03:34:35PM -0700, yaneurabeya@gmail.com wrote: > On Sep 7, 2014, at 14:08, Glen Barber wrote: >=20 > > On Sun, Sep 07, 2014 at 02:03:35PM -0700, Sean Bruno wrote: > >> make[4]: "/home/sbruno/bsd/fbsd_head/sys/modules/if_gif/Makefile" line > >> 12: warning: Couldn't read shell's output for > >> "cat /home/sbruno/bsd/obj/mips/mips.mips/home/sbruno/bsd/fbsd_head/sys= /WZR-300HP/opt_inet6.h" > >>=20 > >>=20 > >> Shouldn't this cat be done in a saner way? > >>=20 > >=20 > > This is done quite often throughout the tree, and bmake(1) does not like > > it when there is no value assigned from the '!=3D' expansion. > >=20 > > The fix I've seen most commonly done is to echo a newline after the > > assignment, such as: > >=20 > > Index: sys/modules/if_gif/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- sys/modules/if_gif/Makefile (revision 271215) > > +++ sys/modules/if_gif/Makefile (working copy) > > @@ -9,7 +9,7 @@ KMOD=3D if_gif > > SRCS=3D if_gif.c in_gif.c opt_inet.h opt_inet6.h opt_mrouting.h > >=20 > > .if defined(KERNBUILDDIR) > > -OPT_INET6!=3D cat ${KERNBUILDDIR}/opt_inet6.h > > +OPT_INET6!=3D cat ${KERNBUILDDIR}/opt_inet6.h; echo > > .if empty(OPT_INET6) > > MK_INET6_SUPPORT=3Dno > > .endif >=20 > Shouldn=E2=80=99t this all be removed and replaced with equivalent logic = provided by kern.opts.mk? Probably. Glen --R6sEYoIZpp9JErk7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJUDRWxAAoJELls3eqvi17QtBYQAMsa5gqje3unXKAgz+xZHzrV g0/6XQG45+XvG2lQPq7Qk4JR4ONSuGxTwmucIQhqRfh0rMxkDdBzQ8Xv/REON0O6 f0WmmTpS4w7jJUmRzjWm9bSvkOrFeGfvJEh2gFACXhtrpeYejRHvWXBlueyxeTcQ brHc4xo55X2FMpW4WddJcVsZHuM7j7+5bsOtkA7A+O4h9qpG7iqVNZE0RHpTO/Ht aM+BOLcmvuT1zx6YJyf/Us792NE/7l/JZYMgOE1tSydN2VwOK/X9koaOhb5JjF2j +v0lLBztq+NXJQdF9Le0B5uVpf5lhQvLY0XwMFAvBUY+qk5kxIr+SZbXB+zmpW1y QPE/bqCm9KbiGKqstwM1WSVLSB261F0LHUteCbXXrrMdj6f8SokWgOXrJrPs539o QEsq/f68rilQshCk+Zziqri6M34hjyAogHg8riItEIIksGDUq0sLAW1b8ChnvmlP BHYg89mgMoI87MDvRRDYe0yn6JqSo7ohBOW2QEPLkvOAdImr2dJGnYoxWqhd7d7A 60ADHrqbRae7wnl0dg36e2zVlkawRKdTqCv9Qgg2RT5FyzqE0mLP4EWyP2HwIXvY 3lSZ1dVKjbTsz3DdUeuFq/Y/Z3GPWJ10omFlBi51mrfAp2srGEFIkjTlzTo7IyEg xfm1JWK37P/gKORiUXTg =3gqA -----END PGP SIGNATURE----- --R6sEYoIZpp9JErk7--