From owner-freebsd-stable@FreeBSD.ORG Thu Apr 11 17:42:43 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 4D31E979 for ; Thu, 11 Apr 2013 17:42:43 +0000 (UTC) (envelope-from markiyan.kushnir@gmail.com) Received: from mail-ea0-x22e.google.com (mail-ea0-x22e.google.com [IPv6:2a00:1450:4013:c01::22e]) by mx1.freebsd.org (Postfix) with ESMTP id D6E9DE2A for ; Thu, 11 Apr 2013 17:42:42 +0000 (UTC) Received: by mail-ea0-f174.google.com with SMTP id m14so853537eaj.5 for ; Thu, 11 Apr 2013 10:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=1UGGUlX/9WuhMpXIsZDgEiMKByg4TzPgmgFjz/QyhYI=; b=mOYkYZlbF6gjLF6INxk3DfIWrgDFEXmRFMuB6VM1W3+5ddP2V8d5HcgfL0J6RaeKvv erczkDKsSzpYw/gezQF4mYorYobZGSi4wO5800wpjhywObIp9uJg3dyfzYMz7mSk/aET /XTg/vacMDx9QjMbdEm+sHakdiQ5zGb321UTJWUg06+yumWkKE4D4QQpxlwqrIA0kQ2u UJkw4d02qJFuL06fAUlW9RLMXXc52CD6UfVB0jg5UUeEzSXUNxHZcaTjkFwb6Z6xSVn8 vGbnWifSCQCGjZ+7ngmuoPqeTu/v6FA8oAy/uEOikewko7tnrrj0G/N1hkQ3FxT3apG/ Ufng== X-Received: by 10.14.107.69 with SMTP id n45mr19001306eeg.23.1365702161802; Thu, 11 Apr 2013 10:42:41 -0700 (PDT) Received: from mkushnir.zapto.org (162-69-132-95.pool.ukrtel.net. [95.132.69.162]) by mx.google.com with ESMTPS id i53sm6817911eeu.5.2013.04.11.10.42.40 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 11 Apr 2013 10:42:41 -0700 (PDT) Message-ID: <5166F605.4080602@gmail.com> Date: Thu, 11 Apr 2013 20:42:29 +0300 From: Markiyan Kushnir User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:16.0) Gecko/20121119 Thunderbird/16.0.2 MIME-Version: 1.0 To: freebsd-stable@freebsd.org Subject: Re: svn - but smaller? References: <88b872cf-7795-4d69-91c7-6c3107299b33@googlegroups.com> <20130411225319.M56386@sola.nimnet.asn.au> In-Reply-To: <20130411225319.M56386@sola.nimnet.asn.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2013 17:42:43 -0000 I agree with Ian, there is no need to statically link to base libraries. While not going into details of the patch, I can confirm no issues, except of known ones, of course: ports/177777, ports/177408. Another thing that might be worth of attention, the patched version has been again back to slower checkout time: real 91m38.824s user 0m26.216s sys 0m13.858s at 4 Mbit/s link, while the original 0.56 takes ~55min given the same load/network conditions. -- Markiyan On 11.04.2013 16:03, Ian Smith wrote: > On Thu, 11 Apr 2013, mrboco@gmail.com wrote: > > On Sunday, March 24, 2013 9:57:12 AM UTC+6, Markiyan Kushnir wrote: > > > Tested svnup for a while, and I can say it does its job well, and works > > > basically as I would expect, so thanks for your initiative. Although it > > > appears to be quite resource greedy. Most of the time it showed > > > something like: > > > > > > PID USERNAME THR PRI NICE SIZE RES STATE C TIME WCPU COMMAND > > > 22270 mkushnir 1 102 0 44944K 31804K CPU0 1 6:22 97.56% a.out > > > > It's because of typo in the send_command() procedure. > > > > I've placed the patched svnup.c (0.56), the diff and two statically > > linked binaries on http://ftp.ufanet.ru/pub/boco/freebsd/svnup/ > > > > No more CPU eating and/or strange lockups (so far). Tested both > > against local and remote repository. > > I'm sorry, but even ignoring all of your whitespace and style(9) > differences, your patch appears to go well beyond correcting a typo, > which I can't spot anyway, though I'm sure John will know what it is. > > Care to explain a little more? > > Also, what advantage, in this particular case, is there in statically > linking? Here it turns a 21.5K i386 binary into one of 575K. If this > makes it into base, as I hope it may, that seems a little excessive? > > cheers, Ian > _______________________________________________ > freebsd-stable@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org" >