From owner-cvs-src@FreeBSD.ORG Thu Mar 3 18:48:21 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E221316A4D8; Thu, 3 Mar 2005 18:48:21 +0000 (GMT) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id D13B743D6D; Thu, 3 Mar 2005 18:48:20 +0000 (GMT) (envelope-from jkim@niksun.com) Received: from [10.70.0.244] (daemon.mj.niksun.com [10.70.0.244]) by anuket.mj.niksun.com (8.13.1/8.12.11) with ESMTP id j23ImHHi043190; Thu, 3 Mar 2005 13:48:17 -0500 (EST) (envelope-from jkim@niksun.com) From: Jung-uk Kim Organization: Niksun, Inc. To: Bill Paul Date: Thu, 3 Mar 2005 13:48:14 -0500 User-Agent: KMail/1.6.2 References: <200503031735.j23HZ5hv094849@repoman.freebsd.org> In-Reply-To: <200503031735.j23HZ5hv094849@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200503031348.14325.jkim@niksun.com> X-Virus-Scanned: ClamAV 0.83/743/Wed Mar 2 19:02:05 2005 on anuket.mj.niksun.com X-Virus-Status: Clean cc: cvs-src@freebsd.org cc: src-committers@freebsd.org Subject: Re: cvs commit: src/sys/net80211 ieee80211_ioctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2005 18:48:22 -0000 On Thursday 03 March 2005 12:35 pm, Bill Paul wrote: > wpaul 2005-03-03 17:35:05 UTC > > FreeBSD src repository > > Modified files: > sys/net80211 ieee80211_ioctl.c > Log: > Recently, it was reported to me that you could provoke a double > fault panic with the NDISulator if you did "ifconfig ndis0 > 10.0.0.1/24," whereas "ifconfig ndis0 10.0.0.1/24 up" worked fine. > The double fault was caused by the ifconfig thread running out of > kernel stack space. (This was partly due to the NDIsulator using a > couple of big buffers on the stack, but even after fixing that the > double fault persisted.) > > It turns out that ndis_init() is called in both cases, but in the > first case the code path passes through ieee80211_ioctl(), and it > turns out ieee80211_ioctl() consumes a whopping 2400 bytes of stack > space. Apparently, gcc -O2 causes the ieee80211_ioctl_get80211() > routine to be inlined into ieee80211_ioctl(), and for some reason > which I do not fully understand, this causes ieee80211_ioctl() to > consume an extra 2K of stack space. > > To prevent this overly agressive optimization, > ieee80211_ioctl_get80211() is now declared with __attribute__ > ((noinline)). With this change, ieee80211_ioctl() now only reserves > about 200 bytes of stack instead of 2400. > > Revision Changes Path > 1.19 +19 -0 src/sys/net80211/ieee80211_ioctl.c Check this commit: http://docs.freebsd.org/cgi/mid.cgi?200503022133.j22LXTih011115 and this comment: http://docs.freebsd.org/cgi/mid.cgi?20050303161436.0cczcopocg84g4ks Thanks, Jung-uk Kim