From owner-svn-src-all@FreeBSD.ORG Wed Nov 5 05:55:10 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 06DA6E60; Wed, 5 Nov 2014 05:55:10 +0000 (UTC) Received: from mail-wi0-x236.google.com (mail-wi0-x236.google.com [IPv6:2a00:1450:400c:c05::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 264411B9; Wed, 5 Nov 2014 05:55:09 +0000 (UTC) Received: by mail-wi0-f182.google.com with SMTP id d1so987830wiv.3 for ; Tue, 04 Nov 2014 21:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=6vQIerk0Akk1olXF0rD1jJCaozWwyiMSwL5xRRMll3k=; b=koSIFdTFiHgHojLzfPwkra39GiYm5e1Mv1wVW8n1blhoFhB37CY2UdafKTV7zOW5QZ B9PAf3V2QeGob4gDigutzKUzfTbbBsc88T5F2dNuYB1D+Sm8jT8KVLbWUvsHSkNCM4pB hkbAvYSE67fywZCTzikwGHjexlUAGT6uxzBYmipLbLf6JOssVNnEhgRmMgigofZSanMK Kry2hpaH7/h1bHjBAHx/SQKQDVWcWCNuyzzAQyec8GVSK0hVu5rnVolqWzflGLPWVHam vM84CxtcpHt+4zFwngZbAPJoKrK4+wyAffY6bwpR4YrjuHIEe2+68tllKfVB32w9EmXh AK9Q== MIME-Version: 1.0 X-Received: by 10.180.83.98 with SMTP id p2mr29058089wiy.20.1415166907476; Tue, 04 Nov 2014 21:55:07 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.106.136 with HTTP; Tue, 4 Nov 2014 21:55:07 -0800 (PST) In-Reply-To: <201410291921.s9TJLKpg005878@svn.freebsd.org> References: <201410291921.s9TJLKpg005878@svn.freebsd.org> Date: Tue, 4 Nov 2014 21:55:07 -0800 X-Google-Sender-Auth: oKRXzByMudN-nFKBdfX_ngDiubM Message-ID: Subject: Re: svn commit: r273835 - head/usr.bin/top From: Adrian Chadd To: Jung-uk Kim Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2014 05:55:10 -0000 Hah, great catch! Thanks! -adrian On 29 October 2014 12:21, Jung-uk Kim wrote: > Author: jkim > Date: Wed Oct 29 19:21:19 2014 > New Revision: 273835 > URL: https://svnweb.freebsd.org/changeset/base/273835 > > Log: > Replace a magic number with the proper definition. This change actually > fixes broken state field after r273266, i.e., "CPU-1" was displayed in place > of "RUN". > > Modified: > head/usr.bin/top/machine.c > > Modified: head/usr.bin/top/machine.c > ============================================================================== > --- head/usr.bin/top/machine.c Wed Oct 29 18:01:09 2014 (r273834) > +++ head/usr.bin/top/machine.c Wed Oct 29 19:21:19 2014 (r273835) > @@ -941,7 +941,7 @@ format_next_process(caddr_t handle, char > /* generate "STATE" field */ > switch (state = pp->ki_stat) { > case SRUN: > - if (smpmode && pp->ki_oncpu != 0xff) > + if (smpmode && pp->ki_oncpu != NOCPU) > sprintf(status, "CPU%d", pp->ki_oncpu); > else > strcpy(status, "RUN"); > @@ -1100,7 +1100,7 @@ format_next_process(caddr_t handle, char > > /* format this entry */ > if (smpmode) { > - if (state == SRUN && pp->ki_oncpu != 0xff) > + if (state == SRUN && pp->ki_oncpu != NOCPU) > cpu = pp->ki_oncpu; > else > cpu = pp->ki_lastcpu; >